| Summary: | WebKit tests for the Qt API should include tests of CMake config files | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | steveire | ||||||
| Component: | WebKit Qt | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | gyuyoung.kim, hausmann, rakuco, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
Comment on attachment 177483 [details]
Add unit test
Patch looks good in general, but please include a ChangeLog.
You can do this for example by calling
Tools/Scripts/webkit-patch prepare 104003
The number is the number of this bug, so that the ChangeLog will automatically include a reference to this bug.
After calling this command, open the ChangeLog changed files and complete the new entries. Afterwards you can post your patch automatically to bugzilla by using
Tools/Scripts/webkit-patch post
and you can pass --request-commit as parameter to the post command if you'd like to get the patch landed automatically using the commit queue. (you probably want this unless you are a committer yourself or you know somebody how is going to care of landing the change in SVN)
Created attachment 178777 [details]
Patch
Comment on attachment 178777 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=178777&action=review > Source/WebKit/qt/ChangeLog:6 > + Rubber-stamped by Simon Hausmann. This field should've been left as is the NOBODY (OOPS) line) because it's not known in advance who the reviewer is (usually) or if it's a rubber stamp or not. r=me on the patch anyway, I'll land it manually. Committed r137302: <http://trac.webkit.org/changeset/137302> |
Created attachment 177483 [details] Add unit test Patch attached.