Bug 103985

Summary: Many webkitpy module files are executable, have shebang line
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dpranke, eric, levin, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 103991    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Zan Dobersek
Reported 2012-12-04 02:11:44 PST
Many webkitpy module files are executable, have shebang line
Attachments
Patch (26.56 KB, patch)
2012-12-04 02:16 PST, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2012-12-04 02:16:13 PST
Created attachment 177454 [details] Patch
Zan Dobersek
Comment 2 2012-12-04 05:02:52 PST
The GTK port relies on a Jhbuild wrapper that is inserted in webkitpy.common.multiprocessing_bootstrap and is currently relying on webkitpy/layout_tests/run_webkit_tests.py to be an executable. Bug #103991 handles this.
Eric Seidel (no email)
Comment 3 2012-12-04 09:41:44 PST
Comment on attachment 177454 [details] Patch Lgtm
Dirk Pranke
Comment 4 2012-12-04 11:08:42 PST
Comment on attachment 177454 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=177454&action=review > Tools/Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:-163 > - sys.exit(main()) I think this one needed to keep the main block; it's a script that is executed directly.
Dirk Pranke
Comment 5 2012-12-04 11:09:22 PST
(looks fine otherwise).
Zan Dobersek
Comment 6 2012-12-04 12:10:38 PST
Comment on attachment 177454 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=177454&action=review >> Tools/Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:-163 >> - sys.exit(main()) > > I think this one needed to keep the main block; it's a script that is executed directly. It's (also) runnable through Tools/Scripts/update-webgl-conformance-tests. http://trac.webkit.org/browser/trunk/Tools/Scripts/update-webgl-conformance-tests
Dirk Pranke
Comment 7 2012-12-04 12:13:07 PST
Ah, sorry. I didn't realize we had a wrapper. Carry on :).
Zan Dobersek
Comment 8 2012-12-04 12:18:42 PST
Comment on attachment 177454 [details] Patch Clearing flags on attachment: 177454 Committed r136545: <http://trac.webkit.org/changeset/136545>
Zan Dobersek
Comment 9 2012-12-04 12:18:47 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.