Bug 103978

Summary: [V8] Remove IntegerCache::m_initialized
Product: WebKit Reporter: Kentaro Hara <haraken>
Component: WebCore JavaScriptAssignee: Kentaro Hara <haraken>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, japhet, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch haraken: commit-queue-

Kentaro Hara
Reported 2012-12-04 00:26:09 PST
Thanks to r136479, we can now initialize V8 integers in IntegerCache's constructor. We can remove IntegerCache::m_initialized, which slightly improves performance. BTW, v8Integer() looks much slower than JSC's one. (https://docs.google.com/a/google.com/spreadsheet/ccc?key=0ArGPzKNdEGeQdGItaF8yVVVMM2trS3R5VW1heDFmcGc#gid=2)
Attachments
Patch (4.21 KB, patch)
2012-12-04 00:29 PST, Kentaro Hara 		haraken: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2012-12-04 00:29:24 PST
Created attachment 177434 [details] Patch
Kentaro Hara
Comment 2 2012-12-04 00:32:13 PST
I'll replace Persistent handles with ScopedPersistents in a follow-up patch.
Adam Barth
Comment 3 2012-12-04 10:09:27 PST
Comment on attachment 177434 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=177434&action=review > Source/WebCore/bindings/v8/V8ValueCache.cpp:103 > -void IntegerCache::createSmallIntegers(v8::Isolate* isolate) > +IntegerCache::IntegerCache() I probably would have passed in isolate to the constructor, but this is fine too.
Adam Barth
Comment 4 2012-12-04 10:09:35 PST
(In reply to comment #2) > I'll replace Persistent handles with ScopedPersistents in a follow-up patch. Thanks.
Kentaro Hara
Comment 5 2012-12-04 16:33:28 PST
Committed r136590: <http://trac.webkit.org/changeset/136590>
Kentaro Hara
Comment 6 2012-12-04 16:34:02 PST
Comment on attachment 177434 [details] Patch Landed manually.
Note You need to log in before you can comment on or make changes to this bug.