Bug 103961

Summary: nrwt: do less work when ctrl-c'ed
Product: WebKit Reporter: Dirk Pranke <dpranke>
Component: New BugsAssignee: Dirk Pranke <dpranke>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, ojan, rniwa, tony
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 103951    
Bug Blocks: 103824, 103963    
Attachments:
Description Flags
Patch rniwa: review+

Dirk Pranke
Reported 2012-12-03 19:36:10 PST
nrwt: do less work when ctrl-c'ed
Attachments
Patch (5.17 KB, patch)
2012-12-03 19:45 PST, Dirk Pranke 		rniwa: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dirk Pranke
Comment 1 2012-12-03 19:45:45 PST
Created attachment 177397 [details] Patch
Ryosuke Niwa
Comment 2 2012-12-03 20:01:36 PST
Comment on attachment 177397 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=177397&action=review > Tools/Scripts/webkitpy/layout_tests/controllers/manager.py:-435 > - # FIXME: Modify summarize_results to handle retry_summary == None. > - retry_summary = result_summary Do we support this case now? r=me provided that the answer to this question is yes.
Dirk Pranke
Comment 3 2012-12-03 21:43:06 PST
Comment on attachment 177397 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=177397&action=review >> Tools/Scripts/webkitpy/layout_tests/controllers/manager.py:-435 >> - retry_summary = result_summary > > Do we support this case now? r=me provided that the answer to this question is yes. Ah, yes. I missed removing the fixme in the cleanup of the patch.
Dirk Pranke
Comment 4 2012-12-04 14:54:50 PST
Committed r136581: <http://trac.webkit.org/changeset/136581>
Note You need to log in before you can comment on or make changes to this bug.