Bug 103923

Summary:

IndexedDB: remove old transaction backend bootstrap code

Product:

WebKit

Reporter:

Alec Flett <alecflett>

Component:

WebCore Misc.

Assignee:

Alec Flett <alecflett>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, dglazkov, dgrogan, fishd, jamesr, jsbell, tkent+wkapi, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

103922

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch for landing	none

Alec Flett

Reported 2012-12-03 13:44:07 PST

This removes the legacy methods obsoleted by bug 103921

Attachments
Patch (64.62 KB, patch) 2013-01-31 14:05 PST, Alec Flett	no flags	Details Formatted Diff Diff
Patch (67.55 KB, patch) 2013-01-31 14:23 PST, Alec Flett	no flags	Details Formatted Diff Diff
Patch (66.53 KB, patch) 2013-01-31 14:27 PST, Alec Flett	no flags	Details Formatted Diff Diff
Patch (66.50 KB, patch) 2013-01-31 14:55 PST, Alec Flett	no flags	Details Formatted Diff Diff
Patch for landing (66.50 KB, patch) 2013-01-31 17:21 PST, Alec Flett	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Alec Flett

Comment 1 2013-01-31 14:05:01 PST

Created attachment 185857 [details] Patch

WebKit Review Bot

Comment 2 2013-01-31 14:07:53 PST

Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

WebKit Review Bot

Comment 3 2013-01-31 14:08:09 PST

Attachment 185857 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/Modules/indexeddb/IDBCallbacks.h', u'Source/WebCore/Modules/indexeddb/IDBDatabaseBackendImpl.cpp', u'Source/WebCore/Modules/indexeddb/IDBDatabaseBackendImpl.h', u'Source/WebCore/Modules/indexeddb/IDBDatabaseBackendInterface.h', u'Source/WebCore/Modules/indexeddb/IDBObjectStoreBackendImpl.h', u'Source/WebCore/Modules/indexeddb/IDBTransaction.h', u'Source/WebCore/Modules/indexeddb/IDBTransactionBackendImpl.h', u'Source/WebCore/Modules/indexeddb/IDBTransactionBackendInterface.h', u'Source/WebCore/Modules/indexeddb/IDBTransactionCallbacks.h', u'Source/WebCore/Modules/indexeddb/IDBTransactionCoordinator.h', u'Source/WebCore/Target.pri', u'Source/WebCore/WebCore.gypi', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebKit/chromium/ChangeLog', u'Source/WebKit/chromium/WebKit.gyp', u'Source/WebKit/chromium/public/WebIDBCallbacks.h', u'Source/WebKit/chromium/public/WebIDBDatabase.h', u'Source/WebKit/chromium/public/WebIDBTransaction.h', u'Source/WebKit/chromium/public/WebIDBTransactionCallbacks.h', u'Source/WebKit/chromium/src/AssertMatchingEnums.cpp', u'Source/WebKit/chromium/src/IDBCallbacksProxy.cpp', u'Source/WebKit/chromium/src/IDBDatabaseBackendProxy.cpp', u'Source/WebKit/chromium/src/IDBDatabaseBackendProxy.h', u'Source/WebKit/chromium/src/IDBTransactionBackendProxy.cpp', u'Source/WebKit/chromium/src/IDBTransactionBackendProxy.h', u'Source/WebKit/chromium/src/IDBTransactionCallbacksProxy.cpp', u'Source/WebKit/chromium/src/IDBTransactionCallbacksProxy.h', u'Source/WebKit/chromium/src/WebIDBCallbacksImpl.cpp', u'Source/WebKit/chromium/src/WebIDBDatabaseImpl.cpp', u'Source/WebKit/chromium/src/WebIDBDatabaseImpl.h', u'Source/WebKit/chromium/src/WebIDBTransactionCallbacksImpl.cpp', u'Source/WebKit/chromium/src/WebIDBTransactionCallbacksImpl.h', u'Source/WebKit/chromium/src/WebIDBTransactionImpl.cpp', u'Source/WebKit/chromium/src/WebIDBTransactionImpl.h', u'Source/WebKit/chromium/tests/IDBAbortOnCorruptTest.cpp', u'Source/WebKit/chromium/tests/IDBDatabaseBackendTest.cpp']" exit_code: 1 Source/WebCore/Modules/indexeddb/IDBTransactionBackendImpl.h:34: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style.

Alec Flett

Comment 4 2013-01-31 14:23:50 PST

Created attachment 185864 [details] Patch

Alec Flett

Comment 5 2013-01-31 14:27:30 PST

Created attachment 185866 [details] Patch

Alec Flett

Comment 6 2013-01-31 14:46:32 PST

dglazkov@ - one more? Lots of code removal!

Dimitri Glazkov (Google)

Comment 7 2013-01-31 14:53:20 PST

Comment on attachment 185866 [details] Patch I hope this code is safe and happy once it moves to that farm upstate.

Alec Flett

Comment 8 2013-01-31 14:55:51 PST

Created attachment 185873 [details] Patch oops, put back virtual destructor for refcounting

Alec Flett

Comment 9 2013-01-31 17:21:57 PST

Created attachment 185904 [details] Patch for landing

WebKit Review Bot

Comment 10 2013-01-31 19:03:01 PST

Comment on attachment 185904 [details] Patch for landing Clearing flags on attachment: 185904 Committed r141523: <http://trac.webkit.org/changeset/141523>

WebKit Review Bot

Comment 11 2013-01-31 19:03:07 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.