Bug 103893
| Summary: | [Gstreamer] changing MedialElement.src resets volume and mute | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Jussi Kukkonen (jku) <jussi.kukkonen> |
| Component: | Media | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | jussi.kukkonen, pnormand, zan |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Jussi Kukkonen (jku)
Bug 96912 updated the MediaElement volume and mute to more accurately match reality. This causes media/video-volume.html fail: When the element gets a new source url, the volume and mute of the element get updated (once state reaches PAUSED) from the playbin. Previously the volume and mute were only updated when playback started so the test did not show the problem.
We may want to try to make sure that MediaElement volume does not change when we change the src.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Zan Dobersek
The media/video-volume.html layout test (of which the failure expectation is pointing to this bug) was fixed with r142005.
http://trac.webkit.org/changeset/142005
It was the only failure pointing to this bug on the GTK port. The test is now passing on EFL as well. Can we close this bug?
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20-%20webkit.org&showAllRuns=true&tests=media%2Fvideo-volume.html
Philippe Normand
(In reply to comment #1)
> The media/video-volume.html layout test (of which the failure expectation is pointing to this bug) was fixed with r142005.
> http://trac.webkit.org/changeset/142005
>
> It was the only failure pointing to this bug on the GTK port. The test is now passing on EFL as well. Can we close this bug?
> http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20-%20webkit.org&showAllRuns=true&tests=media%2Fvideo-volume.html
One change that patch did was connecting to notify::volume and mute before updating the playbin mute property. Are you ok with that Jussi?
I'd be fine closing this bug, FWIW :)
Jussi Kukkonen (jku)
(In reply to comment #2)
> > It was the only failure pointing to this bug on the GTK port. The test is now passing on EFL as well. Can we close this bug?
> > http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20-%20webkit.org&showAllRuns=true&tests=media%2Fvideo-volume.html
>
> One change that patch did was connecting to notify::volume and mute before updating the playbin mute property. Are you ok with that Jussi?
>
> I'd be fine closing this bug, FWIW :)
That looks just fine to me. Resolving then.