Bug 103892 – [Chromium] Fix issue with hard coded error codes in quota error

• Component: New Bugs
• Status: RESOLVED FIXED

[Erik Arvidsson]

[Chromium] Fix issue with hard coded error codes in quota error

[Erik Arvidsson]

Created attachment 177252 [details]
Patch

[Erik Arvidsson]

This is the first step to fix this.

Once this is in and a WebKit roll is done to Chrome, the next step is to use the enum names in Chrome instead of the hard coded values.

The last step is to then to have these enum values get their values from ExceptionCode.

[WebKit Review Bot]

Please wait for approval from [e-mail], [e-mail], [e-mail], [e-mail] or [e-mail] before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

[Darin Fisher (:fishd, Google)]

Comment on attachment 177252 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=177252&action=review

> Source/WebKit/chromium/public/WebStorageQuotaError.h:39
> +    WebStorageQuotaErrorInvalidModification = 13,

Note:  Please be sure to update AssertMatchingEnums.cpp once there is a WebCore equivalent to these new enum values.

[Erik Arvidsson]

(In reply to comment #4)
> (From update of attachment 177252 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=177252&action=review
> 
> > Source/WebKit/chromium/public/WebStorageQuotaError.h:39
> > +    WebStorageQuotaErrorInvalidModification = 13,
> 
> Note:  Please be sure to update AssertMatchingEnums.cpp once there is a WebCore equivalent to these new enum values.

I added them now since the WebCore side has these already.

[Erik Arvidsson]

Committed r136419: <http://trac.webkit.org/changeset/136419>

[Darin Fisher (:fishd, Google)]

(In reply to comment #5)
> > Note:  Please be sure to update AssertMatchingEnums.cpp once there is a WebCore equivalent to these new enum values.
> 
> I added them now since the WebCore side has these already.

Cool, thanks.