Summary: | [BlackBerry] VKB flickers in and out when tapping on webview after text selection on URL bar | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Sean Wang <xuewen.ok> | ||||||||
Component: | WebKit BlackBerry | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | charles.wei, mifenton, rwlbuis, tonikitoo, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Other | ||||||||||
OS: | Other | ||||||||||
Attachments: |
|
Description
Sean Wang
2012-12-03 03:43:21 PST
Created attachment 177225 [details] patch >It looks safe but that assumes the change event will re trigger, if not we risk having a stale selection >overlay if the layout change modifies it. There is a function "void FrameView::performPostLayoutTasks()" which will call FrameSelection::updateAppearance() on every time the FrameView layout is finished. So I think the selection changing will be notified at last. If we don't ensure it, another solution is to check and layoutIfNeeded at the beginning of "SelectionHandler::selectionPositionChanged()". Comment on attachment 177225 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=177225&action=review LGTM, but please fix the ChangeLog before landing. > Source/WebKit/blackberry/ChangeLog:6 > + Reviewed by NOBODY (OOPS!). What PR and internal reviewer? > Source/WebKit/blackberry/ChangeLog:9 > + At the same time, the thread 5 is executing compositeLayers and it will dispatch thread 5 is a bit imprecise... Created attachment 177637 [details]
patch
Fix change log.
Created attachment 177645 [details]
patch
Fix change log.
Comment on attachment 177645 [details]
patch
commit.
Comment on attachment 177645 [details] patch Clearing flags on attachment: 177645 Committed r136633: <http://trac.webkit.org/changeset/136633> |