Bug 103874

Summary: [BlackBerry] VKB flickers in and out when tapping on webview after text selection on URL bar
Product: WebKit Reporter: Sean Wang <xuewen.ok>
Component: WebKit BlackBerryAssignee: Nobody <webkit-unassigned>
Severity: Normal CC: charles.wei, mifenton, rwlbuis, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Other   
Description Flags
rwlbuis: review+, xuewen.ok: commit-queue-
patch none

Description Sean Wang 2012-12-03 03:43:21 PST
RIM Bug:245678

1) Launch browser and navigate to a site
2) Tap on the URL bar so that the text is highlighted.
3) Press and hold the URL bar.
4) Tap on the webcontent to dismiss selection and CCM


3) The VKB is dismissed and the CCM is displayed on the side.
4) You would see the VKB flicker in and out.


3) The VKB is dismissed and the CCM is displayed on the side.
4) The text selection on the URL bar is dismissed and the CCM disappears.
Comment 1 Sean Wang 2012-12-03 03:53:50 PST
Created attachment 177225 [details]

>It looks safe but that assumes the change event will re trigger, if not we risk having a stale selection
>overlay if the layout change modifies it.

There is a function "void FrameView::performPostLayoutTasks()" which will call FrameSelection::updateAppearance() on every time the FrameView layout is finished. So I think the selection changing will be notified at last.

If we don't ensure it, another solution is to check and layoutIfNeeded at the beginning of "SelectionHandler::selectionPositionChanged()".
Comment 2 Rob Buis 2012-12-04 07:19:53 PST
Comment on attachment 177225 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=177225&action=review

LGTM, but please fix the ChangeLog before landing.

> Source/WebKit/blackberry/ChangeLog:6
> +        Reviewed by NOBODY (OOPS!).

What PR and internal reviewer?

> Source/WebKit/blackberry/ChangeLog:9
> +        At the same time, the thread 5 is executing compositeLayers and it will dispatch

thread 5 is a bit imprecise...
Comment 3 Sean Wang 2012-12-04 18:27:10 PST
Created attachment 177637 [details]

Fix change log.
Comment 4 Sean Wang 2012-12-04 18:57:58 PST
Created attachment 177645 [details]

Fix change log.
Comment 5 Charles Wei 2012-12-04 19:18:33 PST
Comment on attachment 177645 [details]

Comment 6 WebKit Review Bot 2012-12-04 21:12:08 PST
Comment on attachment 177645 [details]

Clearing flags on attachment: 177645

Committed r136633: <http://trac.webkit.org/changeset/136633>
Comment 7 Rob Buis 2013-01-04 09:48:37 PST
Landed in r136633, closing.