Bug 103871

Summary: Remove useless included header and change position of Proximity Events test cases
Product: WebKit Reporter: Kihong Kwon <kihong.kwon>
Component: WebCore Misc.Assignee: Kihong Kwon <kihong.kwon>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, gyuyoung.kim, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Kihong Kwon
Reported 2012-12-03 02:34:08 PST
Remove useless included header from DeviceProximityEvent.cpp. And change position of Proximity Events test cases from LayoutTests/fast/dom/Proximity to LayoutTests/proximity.
Attachments
Patch (9.79 KB, patch)
2012-12-03 02:47 PST, Kihong Kwon 		no flags
DetailsFormatted DiffDiff
Patch (14.93 KB, patch)
2012-12-03 04:05 PST, Kihong Kwon 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kihong Kwon
Comment 1 2012-12-03 02:47:06 PST
Created attachment 177216 [details] Patch
Kihong Kwon
Comment 2 2012-12-03 02:55:27 PST
Proximity API is implementing under WebCore/Modules. Therefore I change the path of proximity test cases like other features which is in the Modules.(gamepad, batterystatus...)
WebKit Review Bot
Comment 3 2012-12-03 03:38:19 PST
Comment on attachment 177216 [details] Patch Attachment 177216 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15100457 New failing tests: proximity/check-event-deviceproximity.html proximity/create-event-deviceproximity.html
Kihong Kwon
Comment 4 2012-12-03 04:05:28 PST
Created attachment 177229 [details] Patch
Antonio Gomes
Comment 5 2012-12-03 04:26:27 PST
Comment on attachment 177229 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=177229&action=review > Source/WebCore/ChangeLog:11 > + should be "it"
WebKit Review Bot
Comment 6 2012-12-03 04:49:12 PST
Comment on attachment 177229 [details] Patch Clearing flags on attachment: 177229 Committed r136385: <http://trac.webkit.org/changeset/136385>
WebKit Review Bot
Comment 7 2012-12-03 04:49:16 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.