Bug 103871

Summary: Remove useless included header and change position of Proximity Events test cases
Product: WebKit Reporter: Kihong Kwon <kihong.kwon>
Component: WebCore Misc.Assignee: Kihong Kwon <kihong.kwon>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, gyuyoung.kim, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Kihong Kwon 2012-12-03 02:34:08 PST 
Remove useless included header from DeviceProximityEvent.cpp.
And change position of Proximity Events test cases from LayoutTests/fast/dom/Proximity to LayoutTests/proximity.
Comment 1 Kihong Kwon 2012-12-03 02:47:06 PST 
Created attachment 177216 [details]
Patch
Comment 2 Kihong Kwon 2012-12-03 02:55:27 PST 
Proximity API is implementing under WebCore/Modules.
Therefore I change the path of proximity test cases like other features which is in the Modules.(gamepad, batterystatus...)
Comment 3 WebKit Review Bot 2012-12-03 03:38:19 PST 
Comment on attachment 177216 [details]
Patch

Attachment 177216 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/15100457

New failing tests:
proximity/check-event-deviceproximity.html
proximity/create-event-deviceproximity.html
Comment 4 Kihong Kwon 2012-12-03 04:05:28 PST 
Created attachment 177229 [details]
Patch
Comment 5 Antonio Gomes 2012-12-03 04:26:27 PST 
Comment on attachment 177229 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=177229&action=review

> Source/WebCore/ChangeLog:11
> +

should be "it"
Comment 6 WebKit Review Bot 2012-12-03 04:49:12 PST 
Comment on attachment 177229 [details]
Patch

Clearing flags on attachment: 177229

Committed r136385: <http://trac.webkit.org/changeset/136385>
Comment 7 WebKit Review Bot 2012-12-03 04:49:16 PST 
All reviewed patches have been landed.  Closing bug.