Bug 103853

Summary:

Fix text direction in datalist popup for time controls

Product:

WebKit

Reporter:

Keishi Hattori <keishi>

Component:

Forms

Assignee:

Keishi Hattori <keishi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

tkent, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Description Keishi Hattori 2012-12-02 22:03:55 PST

Fix text direction in datalist popup for time controls

Comment 1 Keishi Hattori 2012-12-02 22:15:18 PST

Created attachment 177179 [details]
Patch

Comment 2 Kent Tamura 2012-12-02 22:31:00 PST

Comment on attachment 177179 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=177179&action=review

> Source/WebCore/Resources/pagepopups/suggestionPicker.css:46
> +.locale-rtl .suggestion-list-entry .title {
> +    direction: rtl;
> +}

We had better have tests for this case.

Comment 3 Keishi Hattori 2012-12-02 23:01:00 PST

Created attachment 177186 [details]
Patch

Comment 4 WebKit Review Bot 2012-12-03 02:30:19 PST

Comment on attachment 177186 [details]
Patch

Rejecting attachment 177186 [details] from commit-queue.

New failing tests:
inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html
Full output: http://queues.webkit.org/results/15097478

Comment 5 WebKit Review Bot 2012-12-05 04:57:26 PST

Comment on attachment 177186 [details]
Patch

Clearing flags on attachment: 177186

Committed r136674: <http://trac.webkit.org/changeset/136674>

Comment 6 WebKit Review Bot 2012-12-05 04:57:29 PST

All reviewed patches have been landed.  Closing bug.