Bug 103838 – Garden-o-matic shouldn't die when blank JSON results are received.

• Component: New Bugs
• Status: RESOLVED FIXED

[Mike West]

Garden-o-matic shouldn't die when blank JSON results are received.

[Mike West]

Created attachment 177145 [details]
Patch

[Ojan Vafai]

Does this show an error in the UI? If not, we should at least show an error. This points to a bug on the buildbot side *and* it means we're not actually getting data for this bot.

[Mike West]

No. It throws an exception, and the UI sticks at "Loading commit data...".

Oh, sorry, you mean after this patch. I don't know, honestly. :) This is what would happen if the XHR request errored out (e.g. the error event is bound to 'callback({})', so if that visually errors off, this would too.

[Ojan Vafai]

(In reply to comment #3)
> Oh, sorry, you mean after this patch. I don't know, honestly. :) This is what would happen if the XHR request errored out (e.g. the error event is bound to 'callback({})', so if that visually errors off, this would too.

I see. I think we show an error in that case. Either way, this patch seems fine since we should fix it to show an error if the XHR fails if we don't already.

[Mike West]

Cool. Then I'll throw it into the queue (thanks for the r+, Adam. :) ).

[WebKit Review Bot]

Comment on attachment 177145 [details]
Patch

Rejecting attachment 177145 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
Kit/chromium/third_party/yasm/source/patched-yasm --revision 167605 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
52>At revision 167605.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/15104234

[Mike West]

Created attachment 177148 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 177148 [details]
Patch for landing

Clearing flags on attachment: 177148

Committed r136352: <http://trac.webkit.org/changeset/136352>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.