Bug 103810 – CSP 1.1 tests are failing under GTK.

• Component: WebCore Misc.
• Status: RESOLVED FIXED

[Mike West]

We just flipped the CSP_NEXT flag to be runtime enabled. I'm not sure how to make that work correctly under GTK, so I'll skip the tests for the moment.

[Mike West]

Skipped in r136307.

Adam, Zan, can one of you point me in the right direction for supporting this feature for non-Chromium ports? I'm happy to do the work, I just don't see anything obvious (nothing in Tools/DumpRenderTree/gtk seems to make use of runtime enabled anything...).

Thanks!

[Zan Dobersek]

(In reply to comment #1)
> Skipped in r136307.
> 
> Adam, Zan, can one of you point me in the right direction for supporting this feature for non-Chromium ports? I'm happy to do the work, I just don't see anything obvious (nothing in Tools/DumpRenderTree/gtk seems to make use of runtime enabled anything...).
> 
> Thanks!

Non-Chromium ports usually enable runtime features through either the DumpRenderTreeSupport object, which presents a bridge of some sorts between DRT and WebCore, or by adding an appropriate setting to the port-specific API (WebKitWebSettings for GTK, QWebSettings for QT etc.).

In case of a feature under development the runtime feature enablement is done through the DumpRenderTreeSupport (for GTK that's in Source/WebKit/gtk/WebCoreSupport). There is already similar work present there that you can orientate by, for instance enabling the Shadow DOM feature.

[Mike West]

Created attachment 177099 [details]
Patch

[Mike West]

(In reply to comment #3)
> Created an attachment (id=177099) [details]
> Patch

Thanks for the detailed explanation. The patch looks pretty straightforward. :)

[Zan Dobersek]

Comment on attachment 177099 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=177099&action=review

> Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp:706
> +    RuntimeEnabledFeatures::setExperimentalContentSecurityFeaturesEnabled(enabled);

Oops, missing 'Policy' in there (that's why it doesn't compile), otherwise the patch is OK. Thanks!

[Mike West]

(In reply to comment #5)
> (From update of attachment 177099 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=177099&action=review
> 
> > Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp:706
> > +    RuntimeEnabledFeatures::setExperimentalContentSecurityFeaturesEnabled(enabled);
> 
> Oops, missing 'Policy' in there (that's why it doesn't compile), otherwise the patch is OK. Thanks!

Ugh. I can't type. I'll spin a new patch in a moment. :)

[Mike West]

Created attachment 177104 [details]
Patch

[Mike West]

Comment on attachment 177104 [details]
Patch

Thanks, Adam. :)

[WebKit Review Bot]

Comment on attachment 177104 [details]
Patch

Clearing flags on attachment: 177104

Committed r136339: <http://trac.webkit.org/changeset/136339>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.