Bug 103804

Summary: Avoid calling into NSUserDefaults every time we start a scroll
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: REOPENED    
Severity: Normal CC: ap, bdakin, mitz, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch mitz: review+

Simon Fraser (smfr)
Reported 2012-11-30 22:01:36 PST
Avoid calling into NSUserDefaults every time we start a scroll
Attachments
Patch (1.74 KB, patch)
2012-11-30 22:03 PST, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Patch (1.73 KB, patch)
2012-11-30 22:04 PST, Simon Fraser (smfr) 		mitz: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2012-11-30 22:03:30 PST
Created attachment 177083 [details] Patch
Simon Fraser (smfr)
Comment 2 2012-11-30 22:04:41 PST
Created attachment 177084 [details] Patch
mitz
Comment 3 2012-11-30 22:08:14 PST
Comment on attachment 177084 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=177084&action=review > Source/WebCore/platform/mac/ScrollAnimatorMac.mm:638 > + NSString* prefName = key? scrollAnimationDefaultsKey?
Simon Fraser (smfr)
Comment 4 2012-11-30 22:13:30 PST
http://trac.webkit.org/changeset/136303
Darin Adler
Comment 5 2012-12-01 08:12:39 PST
Comment on attachment 177084 [details] Patch Can this setting be changed by the user while a process is running? If so, what code would we need to write to make sure we’d actually respond to that change?
Simon Fraser (smfr)
Comment 6 2012-12-01 11:44:49 PST
Sorry, I failed to address that in the commit message. There is no user-visible UI to change this setting on Mountain Lion. On Lion there is...so maybe I am only able to cache post-Lion.
Alexey Proskuryakov
Comment 7 2012-12-03 11:11:27 PST
I think that reading this preference needs to move to UI process. What we care about what the preference is in main process, not in WebProcess.
Note You need to log in before you can comment on or make changes to this bug.