Bug 103773 – Late-loading stylesheets can cause composited layers to be blank

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[Simon Fraser (smfr)]

Loading http://philosophically.com/why-were-pivoting-from-mobile-first-to-web-first on TOT often shows big blank areas.

[Simon Fraser (smfr)]

<rdar://problem/12763281>

[Simon Fraser (smfr)]

Created attachment 177024 [details]
Patch

[Tim Horton]

Comment on attachment 177024 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=177024&action=review

> Source/WebCore/ChangeLog:9
> +        is pending, which is done to avoid a FOUC. When the stylesheet finally loaded,

Probably spell it out?

> Source/WebCore/rendering/RenderLayerCompositor.h:148
> +    // Repaint parts of all composited layers that intersect the given absolute rectangle (or the entire layer if the pointer is null).
> +    void repaintCompositedLayers(const IntRect* = 0);

This mechanism makes for some slightly unusual looking code elsewhere...

> Source/WebCore/rendering/RenderView.h:-84
> -    virtual void repaintViewRectangle(const LayoutRect&, bool immediate = false) const;
> +    void repaintViewRectangle(const LayoutRect&, bool immediate = false) const;
>      // Repaint the view, and all composited layers that intersect the given absolute rectangle.
>      // FIXME: ideally we'd never have to do this, if all repaints are container-relative.
> -    virtual void repaintRectangleInViewAndCompositedLayers(const LayoutRect&, bool immediate = false);

These weren't virtual for a reason?

[Simon Fraser (smfr)]

http://trac.webkit.org/changeset/136277