Bug 103752 – Web Inspector: [Overrides] Add ability to override the page CSS media type

• Component: Web Inspector (Deprecated)
• Status: RESOLVED FIXED

[Alexander Pavlov (apavlov)]

It would be great to have an ability switching media type of the page to print in the DevTools to see what CSS get applied and the result html.

Upstreaming http://code.google.com/p/chromium/issues/detail?id=161496

[Alexander Pavlov (apavlov)]

Created attachment 176980 [details]
Patch

[Andrey Kosyakov]

Comment on attachment 176980 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=176980&action=review

> Source/WebCore/page/FrameView.cpp:1339
> +    if (InspectorInstrumentation::shouldEmulatePrintMedia(m_frame.get()))
> +        overrideType = "print";

Why not make it generic -- i.e. allow to override to arbitrary media type?

[Pavel Feldman]

Comment on attachment 176980 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=176980&action=review

> Source/WebCore/inspector/Inspector.json:435
> +                    { "name": "enabled", "type": "boolean", "description": "Whether the printed media emulation should be enabled." }

Lets keep it generic in the protocol.

> Source/WebCore/inspector/front-end/SettingsScreen.js:331
> +        const p = document.createElement("p");

This should be a part of the overrides

>> Source/WebCore/page/FrameView.cpp:1339
>> +        overrideType = "print";
> 
> Why not make it generic -- i.e. allow to override to arbitrary media type?

+1

[Alexander Pavlov (apavlov)]

Created attachment 177204 [details]
Patch

[Build Bot]

Comment on attachment 177204 [details]
Patch

Attachment 177204 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/15106388

[Alexander Pavlov (apavlov)]

Created attachment 177211 [details]
Patch

[Pavel Feldman]

Comment on attachment 177211 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=177211&action=review

> Source/WebCore/inspector/InspectorPageAgent.cpp:378
> +

accidental change?

[Andrey Kosyakov]

Comment on attachment 177211 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=177211&action=review

> Source/WebCore/inspector/front-end/OverridesView.js:615
> +            if (mediaType === "all") {
> +                // "all" is not a device-specific media type.
> +                continue;
> +            }

Just remove "all" from the array?

> Source/WebCore/inspector/front-end/OverridesView.js:621
> +            if (mediaType === "print")
> +                mediaSelectElement.selectedIndex = i;

this looks a bit fishy... wouldn't it be better to persist the default selection?

[Alexander Pavlov (apavlov)]

Comment on attachment 177211 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=177211&action=review

>> Source/WebCore/inspector/InspectorPageAgent.cpp:378
>> +
> 
> accidental change?

Indeed!

>> Source/WebCore/inspector/front-end/OverridesView.js:615
>> +            }
> 
> Just remove "all" from the array?

I had thought about this at first, but having a "pure-device" set of media types next to the full set thereof sounds bad (in fact, we do need the latter in the CSS tokenizer, so this could be refactored barring one weird value there).

>> Source/WebCore/inspector/front-end/OverridesView.js:621
>> +                mediaSelectElement.selectedIndex = i;
> 
> this looks a bit fishy... wouldn't it be better to persist the default selection?

A nice idea. Implemented.

[Alexander Pavlov (apavlov)]

Created attachment 177450 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 177450 [details]
Patch for landing

Rejecting attachment 177450 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
ripts/update-webkit line 152.

Failed to run "['Tools/Scripts/update-webkit', '--chromium', '--force-update']" exit_code: 2
Updating OpenSource
From http://git.chromium.org/external/Webkit
   eb9e8cc..96514be  HEAD       -> origin/HEAD
error: Ref refs/remotes/origin/master is at 96514be36664e1430392d9b2fd3200c2aab861f9 but expected eb9e8ccd030f66f658b9fcdabeeb134aaaf82783
 ! eb9e8cc..96514be  master     -> origin/master  (unable to update local ref)
Died at Tools/Scripts/update-webkit line 152.

Full output: http://queues.webkit.org/results/15120776

[Alexander Pavlov (apavlov)]

Committed r136493: <http://trac.webkit.org/changeset/136493>

[Alexander Pavlov (apavlov)]

*** Bug 13530 has been marked as a duplicate of this bug. ***