Bug 103733 – [CMAKE] Update UseV8.cmake

• Component: WebKit EFL
• Status: RESOLVED WONTFIX

[Gyuyoung Kim]

I wanna support V8 js engine as well as SFX on EFL port. However, I don't have perfect solution yet. I submit initial WIP patch for now.

[Gyuyoung Kim]

Created attachment 176940 [details]
WIP

[Gyuyoung Kim]

Created attachment 177415 [details]
Patch

[Gyuyoung Kim]

Though people objected to use V8 in WK2, we use V8 engine locally. So, it would be good to keep UseV8.cmake for us. This patch updates V8 binding files with latest and add a cmake build option(cmakearg="-DUSE_V8=ON") as well.

[Gyuyoung Kim]

CC'ing Kentaro, Patrick and Jaehun.

[Gyuyoung Kim]

(In reply to comment #4)
> CC'ing Kentaro, Patrick and Jaehun.

Kubo, any comments ?

[Raphael Kubo da Costa (:rakuco)]

Well, this specific patch doesn't hurt so I have nothing against it. As for actually supporting V8 with EFL and WK2, it's probably a bigger issue (I remember the Qt guys had many problems with that at least).

[Gyuyoung Kim]

(In reply to comment #6)
> Well, this specific patch doesn't hurt so I have nothing against it. As for actually supporting V8 with EFL and WK2, it's probably a bigger issue (I remember the Qt guys had many problems with that at least).

yes, you're right. Apple folks didn't like to support V8 for WK2. So, I think it is not easy to support V8 for WK2 port. This file is just for Tizen local experimental project. If you guys accept to land this patch, it will help to work for us locally. It looks Kentaro and you don't object to land this.

[Antonio Gomes]

(In reply to comment #7)
> (In reply to comment #6)
> > Well, this specific patch doesn't hurt so I have nothing against it. As for actually supporting V8 with EFL and WK2, it's probably a bigger issue (I remember the Qt guys had many problems with that at least).
> 
> yes, you're right. Apple folks didn't like to support V8 for WK2. So, I think it is not easy to support V8 for WK2 port. This file is just for Tizen local experimental project. If you guys accept to land this patch, it will help to work for us locally. It looks Kentaro and you don't object to land this.

If this is to be used downstream, it should not land upstream.

[Kentaro Hara]

(In reply to comment #8)
> > yes, you're right. Apple folks didn't like to support V8 for WK2. So, I think it is not easy to support V8 for WK2 port. This file is just for Tizen local experimental project. If you guys accept to land this patch, it will help to work for us locally. It looks Kentaro and you don't object to land this.
> 
> If this is to be used downstream, it should not land upstream.

The point would be whether you have a concrete plan for upstreaming. If yes, I'd support landing cmake changes. Otherwise, (i.e. if it's just for Tizen *local* experiment), it would make sense to keep it downstream until you get ready to upstream it.

[Gyuyoung Kim]

(In reply to comment #9)
> (In reply to comment #8)
> > > yes, you're right. Apple folks didn't like to support V8 for WK2. So, I think it is not easy to support V8 for WK2 port. This file is just for Tizen local experimental project. If you guys accept to land this patch, it will help to work for us locally. It looks Kentaro and you don't object to land this.
> > 
> > If this is to be used downstream, it should not land upstream.
> 
> The point would be whether you have a concrete plan for upstreaming. If yes, I'd support landing cmake changes. Otherwise, (i.e. if it's just for Tizen *local* experiment), it would make sense to keep it downstream until you get ready to upstream it.

Ok, thanks. I will file a new bug when we ready to upstream. I close this bug