Summary: | [Shadow DOM]: reset-style-inheritance doesn't work for insertion point | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Sergey G. Grekhov <sgrekhov> | ||||||||
Component: | CSS | Assignee: | Takashi Sakamoto <tasak> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | morrita, ojan.autocc, ojan, webcomponents-bugzilla, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 63606, 103230, 103709 | ||||||||||
Attachments: |
|
Description
Sergey G. Grekhov
2012-11-29 22:11:20 PST
Created attachment 177881 [details]
Patch
This patch will also fix bug 103709, [Shadow DOM]: reset-style-inheritance flag doesn't work for shadow insertion point. Comment on attachment 177881 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=177881&action=review > Source/WebCore/html/shadow/InsertionPoint.cpp:168 > +void InsertionPoint::parseAttribute(const QualifiedName& name, const AtomicString& value) This isn't enough. We need to reflect reflect change on resetStyleInheritance property to the attribute value. In general, we no longer need a boolean flag on the class. That can be represented as an attribute value. See how HTMLButtonElement#disabled is implemented. Created attachment 178135 [details]
Patch
Comment on attachment 177881 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=177881&action=review Thank you for reviewing. >> Source/WebCore/html/shadow/InsertionPoint.cpp:168 >> +void InsertionPoint::parseAttribute(const QualifiedName& name, const AtomicString& value) > > This isn't enough. We need to reflect reflect change on resetStyleInheritance property to the attribute value. > In general, we no longer need a boolean flag on the class. That can be represented as an attribute value. > See how HTMLButtonElement#disabled is implemented. I see. I removed m_shouldResetStyleInheritance and modified to look up at reset-style-inheritance attribute value. Comment on attachment 178135 [details] Patch Rejecting attachment 178135 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: dow/InsertionPoint.cpp.rej patching file Source/WebCore/html/shadow/InsertionPoint.h patching file LayoutTests/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file LayoutTests/fast/dom/shadow/insertion-point-resetStyleInheritance-expected.txt patching file LayoutTests/fast/dom/shadow/insertion-point-resetStyleInheritance.html Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Hajime Mor..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue Full output: http://queues.webkit.org/results/15210033 Created attachment 178469 [details]
Patch
Comment on attachment 178469 [details] Patch Clearing flags on attachment: 178469 Committed r137112: <http://trac.webkit.org/changeset/137112> All reviewed patches have been landed. Closing bug. (In reply to comment #10) > All reviewed patches have been landed. Closing bug. It looks test on shadow dom test suite continues failing even after this change. Filed 107229. |