[EFL][WK2][AC] USE_GRAPHICS_SURFACE should be enabled only if Xcomposite and Xrender extensions are found

• Component: WebKit EFL
• Status: RESOLVED FIXED

[Kalyan]

When using GLX back-end we are dependent on GLX support, Xcomposite and Xrender extensions.
In this case GraphicsSurface usage depends on Xcomposite and Xrender extensions. USE_GRAPHICS_SURFACE should be enabled only if Xcomposite and Xrender extensions are found.

[Kalyan]

(In reply to comment #0)
> When using GLX back-end we are dependent on GLX support, Xcomposite and Xrender extensions.
> In this case GraphicsSurface usage depends on Xcomposite and Xrender extensions. USE_GRAPHICS_SURFACE should be enabled only if Xcomposite and Xrender extensions are found.

This is in case of WebGL

[Kalyan]

Created attachment 176906 [details]
GraphicsSurfaceConfig

[Kalyan]

Comment on attachment 176906 [details]
GraphicsSurfaceConfig

removing review flag. Will update a new patch. In PlatformSurface the check should be done using USE rather than HAVE(GRAPHICS_SURFACE)

[Kalyan]

Created attachment 176908 [details]
GraphicsSurfaceConfig

[Kenneth Rohde Christiansen]

Comment on attachment 176908 [details]
GraphicsSurfaceConfig

View in context: https://bugs.webkit.org/attachment.cgi?id=176908&action=review

> ChangeLog:4
> +        [EFL][WK2][AC] USE_GRAPHICS_SURFACE should be enabled only if Xcomposite and Xrender extensions are found.
> +        https://bugs.webkit.org/show_bug.cgi?id=103710.

I guess we need similar checks for EGL

> Source/cmake/OptionsEfl.cmake:196
> -  SET (ENABLE_WEBGL 1)
> -  ADD_DEFINITIONS(-DWTF_USE_GRAPHICS_SURFACE=1)
> +    SET(ENABLE_WEBGL 1)
> +    IF (USE_GRAPHICS_SURFACE)
> +        ADD_DEFINITIONS(-DWTF_USE_GRAPHICS_SURFACE=1)
> +    ENDIF()
>  ENDIF()
>  

isnt the identation wrong?

[Kalyan]

(In reply to comment #5)
> (From update of attachment 176908 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=176908&action=review
> 
> > ChangeLog:4
> > +        [EFL][WK2][AC] USE_GRAPHICS_SURFACE should be enabled only if Xcomposite and Xrender extensions are found.
> > +        https://bugs.webkit.org/show_bug.cgi?id=103710.
> 
> I guess we need similar checks for EGL

Yes, once we start adding support for EGL

> > Source/cmake/OptionsEfl.cmake:196
> > -  SET (ENABLE_WEBGL 1)
> > -  ADD_DEFINITIONS(-DWTF_USE_GRAPHICS_SURFACE=1)
> > +    SET(ENABLE_WEBGL 1)
> > +    IF (USE_GRAPHICS_SURFACE)
> > +        ADD_DEFINITIONS(-DWTF_USE_GRAPHICS_SURFACE=1)
> > +    ENDIF()
> >  ENDIF()
> >  
> 
> isnt the identation wrong?

w.r.t this file the indentation seems to be mixed (2 space and 4 space). But, here https://bugs.webkit.org/show_bug.cgi?id=102687#c9 rakuco mentioned that we should follow 4 space indentation style.

[WebKit Review Bot]

Comment on attachment 176908 [details]
GraphicsSurfaceConfig

Rejecting attachment 176908 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
ommit-queue/Source/WebKit/chromium/third_party/snappy/src --revision 63 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
49>At revision 63.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/15055456

[Kalyan]

Created attachment 177421 [details]
GraphicsSurfaceConfig

[WebKit Review Bot]

Comment on attachment 177421 [details]
GraphicsSurfaceConfig

Clearing flags on attachment: 177421

Committed r136487: <http://trac.webkit.org/changeset/136487>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.