Bug 103630

Summary:

[Qt] Remove an unnecessary masking from swapBgrToRgb()

Product:

WebKit

Reporter:

Gabor Rapcsanyi <rgabor>

Component:

WebKit Qt

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dino, hausmann, noam, webkit.review.bot, zherczeg

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
proposed patch	none

Gabor Rapcsanyi

Reported 2012-11-29 06:02:01 PST

Now swapBgrToRgb() make two masking to get R and B components to the right place: return ((pixel << 16) & 0xff0000) | ((pixel >> 16) & 0xff) | (pixel & 0xff00ff00); We can get the same result with just one: return (((pixel << 16) | (pixel >> 16)) & 0x00ff00ff) | (pixel & 0xff00ff00);

Attachments
proposed patch (1.29 KB, patch) 2012-11-29 06:12 PST, Gabor Rapcsanyi	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Gabor Rapcsanyi

Comment 1 2012-11-29 06:12:45 PST

Created attachment 176713 [details] proposed patch

Zoltan Herczeg

Comment 2 2012-12-03 01:50:51 PST

Comment on attachment 176713 [details] proposed patch r=me

WebKit Review Bot

Comment 3 2012-12-03 02:16:09 PST

Comment on attachment 176713 [details] proposed patch Clearing flags on attachment: 176713 Committed r136375: <http://trac.webkit.org/changeset/136375>

WebKit Review Bot

Comment 4 2012-12-03 02:16:13 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.