Bug 103611

Summary: [Shadow] We should have a performance test of distribution for changing select attribute.
Product: WebKit Reporter: Shinya Kawanaka <shinyak>
Component: DOMAssignee: Shinya Kawanaka <shinyak>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, webcomponents-bugzilla, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 102646    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Shinya Kawanaka 2012-11-29 00:51:19 PST
We would like to compare performance between (a) distributing elements using java script and (b) distributing elements using ShadowDOM.
Comment 1 Shinya Kawanaka 2012-11-29 00:53:29 PST
This is a case when select attribute is changed.
Comment 2 Shinya Kawanaka 2012-11-29 01:15:13 PST
Created attachment 176671 [details]
Patch
Comment 3 Hajime Morrita 2012-11-29 01:38:14 PST
Comment on attachment 176671 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=176671&action=review

Could you add these to PerfomanceTests/Skipped so that they don't run regularly? I think this isn't ready for prime time yet.

> PerformanceTests/ShadowDOM/ChangingSelect.html:61
> +    description: "Measure Time without",

What is this meant to say?

> PerformanceTests/ShadowDOM/ChangingSelectWithoutShadow.html:64
> +    description: "Measure Time without",

What is this meant to say?
Comment 4 WebKit Review Bot 2012-11-29 02:16:11 PST
Comment on attachment 176671 [details]
Patch

Attachment 176671 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/15014857

New failing tests:
inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html
Comment 5 Shinya Kawanaka 2012-11-29 02:39:11 PST
(In reply to comment #3)
> (From update of attachment 176671 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=176671&action=review
> 
> Could you add these to PerfomanceTests/Skipped so that they don't run regularly? I think this isn't ready for prime time yet.
> 
> > PerformanceTests/ShadowDOM/ChangingSelect.html:61
> > +    description: "Measure Time without",
> 
> What is this meant to say?
> 
> > PerformanceTests/ShadowDOM/ChangingSelectWithoutShadow.html:64
> > +    description: "Measure Time without",
> 
> What is this meant to say?

Oops...
Comment 6 Shinya Kawanaka 2012-11-29 02:50:52 PST
Created attachment 176685 [details]
Patch
Comment 7 Shinya Kawanaka 2012-11-29 02:55:03 PST
Created attachment 176686 [details]
Patch
Comment 8 WebKit Review Bot 2012-11-29 03:27:22 PST
Comment on attachment 176686 [details]
Patch

Clearing flags on attachment: 176686

Committed r136120: <http://trac.webkit.org/changeset/136120>
Comment 9 WebKit Review Bot 2012-11-29 03:27:25 PST
All reviewed patches have been landed.  Closing bug.