Summary: | [Shadow] We should have a performance test of distribution for changing select attribute. | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Shinya Kawanaka <shinyak> | ||||||||
Component: | DOM | Assignee: | Shinya Kawanaka <shinyak> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | dglazkov, webcomponents-bugzilla, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 102646 | ||||||||||
Attachments: |
|
Description
Shinya Kawanaka
2012-11-29 00:51:19 PST
This is a case when select attribute is changed. Created attachment 176671 [details]
Patch
Comment on attachment 176671 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=176671&action=review Could you add these to PerfomanceTests/Skipped so that they don't run regularly? I think this isn't ready for prime time yet. > PerformanceTests/ShadowDOM/ChangingSelect.html:61 > + description: "Measure Time without", What is this meant to say? > PerformanceTests/ShadowDOM/ChangingSelectWithoutShadow.html:64 > + description: "Measure Time without", What is this meant to say? Comment on attachment 176671 [details] Patch Attachment 176671 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15014857 New failing tests: inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html (In reply to comment #3) > (From update of attachment 176671 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=176671&action=review > > Could you add these to PerfomanceTests/Skipped so that they don't run regularly? I think this isn't ready for prime time yet. > > > PerformanceTests/ShadowDOM/ChangingSelect.html:61 > > + description: "Measure Time without", > > What is this meant to say? > > > PerformanceTests/ShadowDOM/ChangingSelectWithoutShadow.html:64 > > + description: "Measure Time without", > > What is this meant to say? Oops... Created attachment 176685 [details]
Patch
Created attachment 176686 [details]
Patch
Comment on attachment 176686 [details] Patch Clearing flags on attachment: 176686 Committed r136120: <http://trac.webkit.org/changeset/136120> All reviewed patches have been landed. Closing bug. |