Bug 103590

Summary: Test the return value from Node::compareDocumentPositionMake more strictly.
Product: WebKit Reporter: Hayato Ito <hayato>
Component: DOMAssignee: Hayato Ito <hayato>
Status: RESOLVED FIXED    
Severity: Normal CC: webcomponents-bugzilla, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 72352    
Attachments:
Description Flags
Check return values strictly.
none
Patch for landing none

Hayato Ito
Reported 2012-11-28 19:45:18 PST
In LayoutTests/fast/dom/shadow/compare-document-position.html, it might be better to test the return value from Node::compareDocumentPosition more strictly since it can catch a regression in the future.
Attachments
Check return values strictly. (3.99 KB, patch)
2012-11-28 19:50 PST, Hayato Ito 		no flags
DetailsFormatted DiffDiff
Patch for landing (3.93 KB, patch)
2012-11-28 20:43 PST, Hayato Ito 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Hayato Ito
Comment 1 2012-11-28 19:50:54 PST
Created attachment 176628 [details] Check return values strictly.
Shinya Kawanaka
Comment 2 2012-11-28 20:35:30 PST
Comment on attachment 176628 [details] Check return values strictly. View in context: https://bugs.webkit.org/attachment.cgi?id=176628&action=review > LayoutTests/ChangeLog:12 > + ChangeLog diff seems weird. Let me cq-
Hayato Ito
Comment 3 2012-11-28 20:43:34 PST
Created attachment 176634 [details] Patch for landing
WebKit Review Bot
Comment 4 2012-11-28 21:15:57 PST
Comment on attachment 176634 [details] Patch for landing Clearing flags on attachment: 176634 Committed r136090: <http://trac.webkit.org/changeset/136090>
WebKit Review Bot
Comment 5 2012-11-28 21:16:00 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.