Bug 103554 – IndexedDB: Remove duplicate toWireString() and createFromWire() methods in JSC SerializedScriptValue

• Component: New Bugs
• Status: RESOLVED FIXED

[Michael Pruett]

In r135022, duplicate createFromWire() and toWireString() methods were added to the JSC version of SerializedScriptValue. This class already has methods of those same names with quite different implementations guarded by ENABLED(INDEXED_DATABASE). In order to allow the JSC SerializedScriptValue to compile when ENABLE(INDEXED_DATABASE) is turned on, these competing definitions should be resolved.

[Michael Pruett]

Created attachment 176587 [details]
Patch

This patch fixes compilation of the JSC version of SerializedScriptValue.cpp when ENABLE(INDEXED_DATABASE) is turned on.

[Build Bot]

Comment on attachment 176587 [details]
Patch

Attachment 176587 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/15027587

[Kentaro Hara]

Looks good to me, though you need to expose symbols to other files to fix the build problems (see http://trac.webkit.org/wiki/ExportingSymbols).

jsbell, alecflett: would you take a look?

[Build Bot]

Comment on attachment 176587 [details]
Patch

Attachment 176587 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/15028593

[Joshua Bell]

(In reply to comment #3)
> jsbell, alecflett: would you take a look?

LGTM.

[Kentaro Hara]

Comment on attachment 176587 [details]
Patch

Please fix symbol export issues before landing.

[Michael Pruett]

Created attachment 176612 [details]
Patch

I've added SerializedScriptValue's toWireString() and createFromWire() to the Windows and Mac symbol export files.

[Kentaro Hara]

Comment on attachment 176612 [details]
Patch

ok, now bots look happy.

[WebKit Review Bot]

Comment on attachment 176612 [details]
Patch

Rejecting attachment 176612 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

/mnt/git/webkit-commit-queue/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/15013741

[Kentaro Hara]

Comment on attachment 176612 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=176612&action=review

> ChangeLog:6
> +        Reviewed by NOBODY (OOPS!).

Please manually add my name here.

> Source/WebCore/ChangeLog:6
> +        Reviewed by NOBODY (OOPS!).

and here.

[Michael Pruett]

Created attachment 176647 [details]
Patch

I have added Kentaro Hara as the reviewer for this patch in the ChangeLog messages.

[WebKit Review Bot]

Comment on attachment 176647 [details]
Patch

Clearing flags on attachment: 176647

Committed r136097: <http://trac.webkit.org/changeset/136097>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.