Bug 103544

Summary: Make DataLog work on Windows
Product: WebKit Reporter: Roger Fong <roger_fong>
Component: Web Template FrameworkAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, fpizlo, ojan, thorton, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows 7   
Attachments:
Description Flags
patch
none
patch fpizlo: review+

Roger Fong
Reported 2012-11-28 11:53:16 PST
Datalog doesn't work on Windows (also doesn't compile).
Attachments
patch (1.65 KB, patch)
2012-11-28 12:46 PST, Roger Fong 		no flags
DetailsFormatted DiffDiff
patch (1.57 KB, patch)
2012-11-28 12:53 PST, Roger Fong 		fpizlo: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Roger Fong
Comment 1 2012-11-28 12:46:05 PST
Created attachment 176552 [details] patch
Roger Fong
Comment 2 2012-11-28 12:51:03 PST
Comment on attachment 176552 [details] patch Should be currentCurrentProcessId not ThreadId
Roger Fong
Comment 3 2012-11-28 12:53:55 PST
Created attachment 176557 [details] patch
Roger Fong
Comment 4 2012-11-28 15:41:07 PST
http://trac.webkit.org/changeset/136070
Tim Horton
Comment 5 2012-11-28 16:33:47 PST
Comment on attachment 176557 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=176557&action=review > Source/WTF/wtf/DataLog.cpp:49 > +// This path won't work on Windows, make sure to change to something like C:\\Users\\<more path>\\log.txt. > #define DATA_LOG_FILENAME "/tmp/WTFLog" Why is this not #if PLATFORM(WIN)'d so it works out of the box?
Roger Fong
Comment 6 2012-11-28 17:06:52 PST
My impression of the DATA_LOG_FILE is that whoever wants to use the logging will probably change the path anyways to somewhere a little more easier to access than say /tmp/log. If they're going to be changing it anyways then I think it makes sense to only have one place where the file name is specified.
Filip Pizlo
Comment 7 2012-11-28 17:09:58 PST
(In reply to comment #6) > My impression of the DATA_LOG_FILE is that whoever wants to use the logging will probably change the path anyways to somewhere a little more easier to access than say /tmp/log. That's my thinking as well. > > If they're going to be changing it anyways then I think it makes sense to only have one place where the file name is specified.
Note You need to log in before you can comment on or make changes to this bug.