Bug 103531 – [EFL] MiniBrowser does not play Infinite Gangnam Style

• Component: WebKit EFL
• Status: RESOLVED FIXED

[Dominik Röttsches (drott)]

http://static.echonest.com/InfiniteGangnamStyle/ is not supported on MiniBrowser due to missing WebAudio support.

[Philippe Normand]

There is a GStreamer WebAudio backend, I thought EFL was using it. Is it enabled?

[Dominik Röttsches (drott)]

(In reply to comment #1)
> There is a GStreamer WebAudio backend, I thought EFL was using it. Is it enabled?

Will doublecheck, currently the page says WebAudio isn't there, but not sure if it's a navigator-check or really testing for WebAudio.

[Philippe Normand]

You need to enable it at build and runtime (websetting). That website likely checks if the UA can create an audio context or not.

[Philippe Normand]

Well this works fine in GTK if you enable WebAudio at build and runtime :)

[Dominik Röttsches (drott)]

(In reply to comment #4)
> Well this works fine in GTK if you enable WebAudio at build and runtime :)

Okay, thanks for checking ;-) I'll hopefully get around to enabling it soon so that we can have some atmosphere in the office here :-)

[Dominik Röttsches (drott)]

At least for enabling webaudio/oscillator-* test, we need bug 95084 to be closed.

[Dominik Röttsches (drott)]

Created attachment 180171 [details]
Patch

[Dominik Röttsches (drott)]

Comment on attachment 180171 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=180171&action=review

> Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:22
> +#define GLIB_DISABLE_DEPRECATION_WARNINGS 1

Philippe, is this too brutal? Or is this okay, what do you think?

[Philippe Normand]

Comment on attachment 180171 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=180171&action=review

>> Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:22
>> +#define GLIB_DISABLE_DEPRECATION_WARNINGS 1
> 
> Philippe, is this too brutal? Or is this okay, what do you think?

Can't you adapt your build options instead? If not please have this define only for your port.

> Source/WebKit2/UIProcess/API/efl/EwkViewImpl.cpp:168
> +    m_pageProxy->pageGroup()->preferences()->setWebAudioEnabled(true);

As this spec is still experimental other ports (GTK, Qt) have a websetting for this.

[Kenneth Rohde Christiansen]

Comment on attachment 180171 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=180171&action=review

>> Source/WebKit2/UIProcess/API/efl/EwkViewImpl.cpp:168
>> +    m_pageProxy->pageGroup()->preferences()->setWebAudioEnabled(true);
> 
> As this spec is still experimental other ports (GTK, Qt) have a websetting for this.

We are semi-opposed to exposing unneeded settings for features as it is a bit of a can or worms and hard to maintain. It is default on Chrome and iOS, so I think this is fine.

[Dominik Röttsches (drott)]

Created attachment 180330 [details]
Patch

[Dominik Röttsches (drott)]

(In reply to comment #9)
> (From update of attachment 180171 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=180171&action=review
> 
> >> Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:22
> >> +#define GLIB_DISABLE_DEPRECATION_WARNINGS 1
> > 
> > Philippe, is this too brutal? Or is this okay, what do you think?
> 
> Can't you adapt your build options instead? If not please have this define only for your port.

Thanks, I should have thought about that. Yep, moved that into Source/WebCore/PlatformEfl.cmake.

[Dominik Röttsches (drott)]

Committed r138248: <http://trac.webkit.org/changeset/138248>