Bug 103497

Summary: GraphicsSurface: Implement usage of GraphicsSurface for WebGL in WK1.
Product: WebKit Reporter: Zeno Albisser <zeno>
Component: New BugsAssignee: Zeno Albisser <zeno>
Status: RESOLVED FIXED    
Severity: Normal CC: achicu, dino, hausmann, noam, ossy, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
hausmann: review+
patch: Temporary workaround. hausmann: review+

Zeno Albisser
Reported 2012-11-28 02:38:25 PST
GraphicsSurface: Implement usage of GraphicsSurface for WebGL in WK1.
Attachments
Patch (11.26 KB, patch)
2012-11-28 03:12 PST, Zeno Albisser 		hausmann: review+
DetailsFormatted DiffDiff
patch: Temporary workaround. (2.88 KB, patch)
2012-11-28 03:15 PST, Zeno Albisser 		hausmann: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Zeno Albisser
Comment 1 2012-11-28 03:12:40 PST
Created attachment 176438 [details] Patch
Zeno Albisser
Comment 2 2012-11-28 03:15:08 PST
Created attachment 176439 [details] patch: Temporary workaround.
Simon Hausmann
Comment 3 2012-11-28 03:22:23 PST
Comment on attachment 176438 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=176438&action=review > Source/WebCore/ChangeLog:15 > + After blitting the multismaple framebuffer, smaple -> sample :)
Zeno Albisser
Comment 4 2012-11-28 04:09:24 PST
Comment on attachment 176438 [details] Patch Committed r135995.
Zeno Albisser
Comment 5 2012-11-28 04:09:51 PST
Comment on attachment 176439 [details] patch: Temporary workaround. Committed r135996.
Csaba Osztrogonác
Comment 6 2012-11-28 04:12:29 PST
(In reply to comment #5) > (From update of attachment 176439 [details]) > Committed r135996. It broke the ARM build: /mnt/raptor2/slaves/qt5-linux-armv7-release/build/Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp: In member function 'virtual void WebCore::GraphicsContext3DPrivate::paintToTextureMapper(WebCore::TextureMapper*, const WebCore::FloatRect&, const WebCore::TransformationMatrix&, float, WebCore::BitmapTexture*)': /mnt/raptor2/slaves/qt5-linux-armv7-release/build/Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp:216:9: error: 'm_graphicsSurface' was not declared in this scope
Zeno Albisser
Comment 7 2012-11-28 04:15:31 PST
(In reply to comment #6) looking at it right now. Seems like a trivial #ifdef missing.
Zeno Albisser
Comment 8 2012-11-28 04:51:39 PST
(In reply to comment #7) Fixed in r135998.
Zeno Albisser
Comment 9 2012-11-30 07:01:13 PST
*** Bug 101942 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.