Bug 103469 – Need a method to close all idle localstorage databases immediately.

• Component: WebCore Misc.
• Status: RESOLVED FIXED

[Yongjun Zhang]

Currently, if there is no document referencing to a local storage database, the database will be closed in 300 seconds.  It would be nice if we could have a method to close the database without waiting.

[Yongjun Zhang]

<rdar://problem/11858713>

[Yongjun Zhang]

Created attachment 176378 [details]
Add a method to PageGroup to close all idle local storage databases.

[WebKit Review Bot]

Comment on attachment 176378 [details]
Add a method to PageGroup to close all idle local storage databases.

Attachment 176378 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/15010358

[Peter Beverloo (cr-android ews)]

Comment on attachment 176378 [details]
Add a method to PageGroup to close all idle local storage databases.

Attachment 176378 [details] did not pass cr-android-ews (chromium-android):
Output: http://queues.webkit.org/results/15023277

[Yongjun Zhang]

Created attachment 176396 [details]
Fix chrome build break.

[WebKit Review Bot]

Comment on attachment 176396 [details]
Fix chrome build break.

Attachment 176396 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/15013378

New failing tests:
storage/domstorage/localstorage/close-idle-localstorage-databases-immediately.html

[Yongjun Zhang]

Created attachment 176507 [details]
Fix chromium test failure.

[WebKit Review Bot]

Comment on attachment 176507 [details]
Fix chromium test failure.

Attachment 176507 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/15029424

New failing tests:
storage/domstorage/localstorage/close-idle-localstorage-databases-immediately.html

[Yongjun Zhang]

Created attachment 176529 [details]
skip the new test on chromium since the test requires Safari's cache model.

[David Kilzer (:ddkilzer)]

Comment on attachment 176529 [details]
skip the new test on chromium since the test requires Safari's cache model.

View in context: https://bugs.webkit.org/attachment.cgi?id=176529&action=review

r=me with the non-nit issues addressed.

> Source/WebCore/page/PageGroup.cpp:152
> +    if (!pageGroups)

Nit: This variable should be named s_pageGroups and be a static class variable in the PageGroup class instead of a local static variable.
Not necessary to fix this for this patch, though.

> Tools/DumpRenderTree/gtk/TestRunnerGtk.cpp:1003
> +void TestRunner::closeIdleLocalStorageDatabases()
> +{
> +}

Nit:  Could add a FIXME comment here.

> LayoutTests/storage/domstorage/localstorage/close-idle-localstorage-databases-immediately.html:13
> +function log(a)
> +{
> +    document.getElementById("logger").innerHTML += a + "<br>";
> +}

Argument to function should have a better name like "message".

I would prefer it if we used fast/js/resources/js-test-pre.js with the description(), testPassed() and testFailed() functions instead of rolling our own custom messages.  We should also include fast/js/resources/js-test-style.css as a stylesheet for the test.

> LayoutTests/storage/domstorage/localstorage/close-idle-localstorage-databases-immediately.html:36
> +        if (loadCount == 1 ) {

Extra space between "1" and ")".

> LayoutTests/storage/domstorage/localstorage/close-idle-localstorage-databases-immediately.html:57
> +<div id="logger"></div>

"logger" becomes "console" here if we use fast/js/resources/js-test-pre.js.

[Yongjun Zhang]

Created attachment 176765 [details]
slightly modified patch, addressing review comments and use fast/js/resources/js-test-pre.js for presenting test results.

[WebKit Review Bot]

Comment on attachment 176765 [details]
slightly modified patch, addressing review comments and use fast/js/resources/js-test-pre.js for presenting test results.

Rejecting attachment 176765 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
um/third_party/v8-i18n --revision 159 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
51>At revision 159.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...
Total errors found: 0 in 1 files

Full output: http://queues.webkit.org/results/15054088

[Yongjun Zhang]

Created attachment 176812 [details]
Remove OOPS in LayoutTest/ChangeLog

[WebKit Review Bot]

Comment on attachment 176812 [details]
Remove OOPS in LayoutTest/ChangeLog

Rejecting attachment 176812 [details] from commit-queue.

New failing tests:
inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html
Full output: http://queues.webkit.org/results/15036644

[WebKit Review Bot]

Comment on attachment 176812 [details]
Remove OOPS in LayoutTest/ChangeLog

Rejecting attachment 176812 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

Last 500 characters of output:
  return self.open(self.click(*args, **kwds))
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_mechanize.py", line 203, in open
    return self._mech_open(url, data, timeout=timeout)
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_mechanize.py", line 255, in _mech_open
    raise response
webkitpy.thirdparty.autoinstalled.mechanize._response.httperror_seek_wrapper: HTTP Error 500: Internal Server Error

Full output: http://queues.webkit.org/results/15063768

[WebKit Review Bot]

Comment on attachment 176812 [details]
Remove OOPS in LayoutTest/ChangeLog

Clearing flags on attachment: 176812

Committed r136323: <http://trac.webkit.org/changeset/136323>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.