Bug 103462

Summary: run-perf-tests fails on Android because of stderr output
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: dpranke, peter, rniwa, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Adam Barth 2012-11-27 16:08:06 PST 
run-perf-tests fails on Android because of stderr output
Comment 1 Adam Barth 2012-11-27 16:09:31 PST 
Created attachment 176357 [details]
Patch
Comment 2 Ryosuke Niwa 2012-11-27 16:10:44 PST 
Comment on attachment 176357 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=176357&action=review

> Tools/Scripts/webkitpy/performance_tests/perftest.py:106
> +        re.compile(r'^Unknown option:'),
> +        re.compile(r'^\[WARNING:')]

Can we be more specific about warnings?
Comment 3 Adam Barth 2012-11-27 16:11:46 PST 
Comment on attachment 176357 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=176357&action=review

>> Tools/Scripts/webkitpy/performance_tests/perftest.py:106
>> +        re.compile(r'^\[WARNING:')]
> 
> Can we be more specific about warnings?

On IRC we discussed limiting this to proxy_service.cc
Comment 4 Adam Barth 2012-11-27 16:15:11 PST 
Created attachment 176361 [details]
Patch
Comment 5 Adam Barth 2012-11-27 16:19:13 PST 
Created attachment 176363 [details]
Patch
Comment 6 WebKit Review Bot 2012-11-27 16:40:54 PST 
Comment on attachment 176363 [details]
Patch

Clearing flags on attachment: 176363

Committed r135942: <http://trac.webkit.org/changeset/135942>
Comment 7 WebKit Review Bot 2012-11-27 16:40:57 PST 
All reviewed patches have been landed.  Closing bug.