Bug 103402

Summary: Layout Test transitions/transition-shorthand-delay.html should usePauseAPI
Product: WebKit Reporter: Jussi Kukkonen (jku) <jussi.kukkonen>
Component: Tools / TestsAssignee: Jussi Kukkonen (jku) <jussi.kukkonen>
Status: RESOLVED FIXED    
Severity: Normal CC: simon.fraser, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
better Changelog
none
Remove flaky expectation from efl none

Jussi Kukkonen (jku)
Reported 2012-11-27 05:10:38 PST
The following layout test is flaky on Apple MountainLion and Lion but especially on EFL (both WK1 and WK2) transitions/transition-shorthand-delay.html I am able to trigger the failure, although not easily. Looks like a timing issue: -- FAIL - "left" property for "target" element at 0.5s expected: 125 but saw: 133.3804168701172 --
Attachments
Patch (1.46 KB, patch)
2012-11-27 06:43 PST, Jussi Kukkonen (jku) 		no flags
DetailsFormatted DiffDiff
better Changelog (1.50 KB, patch)
2012-11-27 06:48 PST, Jussi Kukkonen (jku) 		no flags
DetailsFormatted DiffDiff
Remove flaky expectation from efl (2.27 KB, patch)
2012-11-27 10:53 PST, Jussi Kukkonen (jku) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Jussi Kukkonen (jku)
Comment 1 2012-11-27 06:31:28 PST
I believe pause API works on transitions nowadays, using it should make this flakiness go away.
Jussi Kukkonen (jku)
Comment 2 2012-11-27 06:43:14 PST
Created attachment 176257 [details] Patch
Jussi Kukkonen (jku)
Comment 3 2012-11-27 06:48:38 PST
Created attachment 176259 [details] better Changelog
Jussi Kukkonen (jku)
Comment 4 2012-11-27 06:50:29 PST
Simon, you added the PauseAPI (non)usage here originally, do you want to review this?
Simon Fraser (smfr)
Comment 5 2012-11-27 08:47:55 PST
Comment on attachment 176259 [details] better Changelog If this change doesn't cause assertions in debug, r=me.
Jussi Kukkonen (jku)
Comment 6 2012-11-27 10:50:44 PST
(In reply to comment #5) > (From update of attachment 176259 [details]) > If this change doesn't cause assertions in debug, r=me. Debug works fine here. Oh, I'll send one more version to remove the flaky expectation from EFL TestExpectations, I assume that's not impolite after r+ -- since I could do it in an unreviewed commit anyway.
Jussi Kukkonen (jku)
Comment 7 2012-11-27 10:53:43 PST
Created attachment 176302 [details] Remove flaky expectation from efl
WebKit Review Bot
Comment 8 2012-11-27 11:17:16 PST
Comment on attachment 176302 [details] Remove flaky expectation from efl Clearing flags on attachment: 176302 Committed r135885: <http://trac.webkit.org/changeset/135885>
WebKit Review Bot
Comment 9 2012-11-27 11:17:19 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.