Bug 103382 – PDFPlugin: Scroll bars do not grow on hover

• Component: PDF
• Status: RESOLVED FIXED

[Tim Horton]

<rdar://problem/12555262>

[Tim Horton]

This also covers non-overlay scrollbars not glowing, etc.

[Tim Horton]

Created attachment 176213 [details]
patch

[Beth Dakin]

Comment on attachment 176213 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=176213&action=review

> Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.mm:436
> +        if (magnification) {

I don't think you need these brackets.

> Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.mm:566
> +        } else if (targetScrollbarForLastMousePosition)

Is 'else if' right here? Will there ever be a situation where you want to sent a mouseEntered for one scrollbar AND a mouseExited for another?

[Tim Horton]

(In reply to comment #3)
> (From update of attachment 176213 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=176213&action=review
> 
> > Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.mm:436
> > +        if (magnification) {
> 
> I don't think you need these brackets.

Nope! They're a figment of debugging, sorry.

> > Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.mm:566
> > +        } else if (targetScrollbarForLastMousePosition)
> 
> Is 'else if' right here? Will there ever be a situation where you want to sent a mouseEntered for one scrollbar AND a mouseExited for another?

Though it will rarely come up in practice, you're right.

Thanks, Beth!

[Tim Horton]

http://trac.webkit.org/changeset/135916