Summary: | DFG SetLocal should use forwardSpeculationCheck instead of its own half-baked version of same | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Filip Pizlo <fpizlo> | ||||
Component: | JavaScriptCore | Assignee: | Filip Pizlo <fpizlo> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | barraclough, ggaren, mark.lam, mhahnenberg, msaboff, oliver, sam | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Filip Pizlo
2012-11-26 20:49:19 PST
Created attachment 176158 [details]
the patch
Comment on attachment 176158 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=176158&action=review > Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:2327 > + // And twice for real. This may be non-obvious, and it's possible the idiom required to make this work could change. I wonder if we should have a helper to set two registers, e.g.: setPair(result, op, srcDst, resultIndex) This could internally perform the four set() calls (as this is currently implemented). (In reply to comment #3) > (From update of attachment 176158 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=176158&action=review > > > Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:2327 > > + // And twice for real. > > This may be non-obvious, and it's possible the idiom required to make this work could change. > I wonder if we should have a helper to set two registers, e.g.: > setPair(result, op, srcDst, resultIndex) > This could internally perform the four set() calls (as this is currently implemented). Good call! I will land with this change unless there are objections. Landed in http://trac.webkit.org/changeset/135923 |