Summary: | :read-only selector should match to date/time input types | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kent Tamura <tkent> | ||||||
Component: | Forms | Assignee: | Kent Tamura <tkent> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | allan.jensen, cmarcelo, haraken, macpherson, menard, mifenton, morrita, ojan, webkit.review.bot, yosin | ||||||
Priority: | P2 | Keywords: | WebExposed | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Kent Tamura
2012-11-26 20:04:53 PST
Created attachment 176180 [details]
Patch
Comment on attachment 176180 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=176180&action=review Looks ok > Source/WebCore/ChangeLog:11 > + isTextFormControl check in SeelctorChecker, and just relies on Typo: SelectorChecker > Source/WebCore/html/HTMLTextAreaElement.cpp:539 > +bool HTMLTextAreaElement::shouldMatchReadOnlySelector() const > +{ > + return readOnly(); > +} > + > +bool HTMLTextAreaElement::shouldMatchReadWriteSelector() const > +{ > + return !readOnly(); Don't you want to change this to: bool HTMLTextAreaElement::shouldMatchReadOnlySelector() const { return supportsReadOnly() && readOnly(); } bool HTMLTextAreaElement::shouldMatchReadWriteSelector() const { return supportsReadOnly() && !readOnly(); } and implement: HTMLTextAreaElement::supportsReadOnly() { return true; } ? Comment on attachment 176180 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=176180&action=review >> Source/WebCore/html/HTMLTextAreaElement.cpp:539 >> + return !readOnly(); > > Don't you want to change this to: > > bool HTMLTextAreaElement::shouldMatchReadOnlySelector() const > { > return supportsReadOnly() && readOnly(); > } > > bool HTMLTextAreaElement::shouldMatchReadWriteSelector() const > { > return supportsReadOnly() && !readOnly(); > } > > and implement: > > HTMLTextAreaElement::supportsReadOnly() { return true; } > > ? It looks to help nothing and makes code readers confused. Created attachment 176186 [details]
Patch for landing
Fix a typo in ChangeLog
Comment on attachment 176186 [details] Patch for landing Clearing flags on attachment: 176186 Committed r135829: <http://trac.webkit.org/changeset/135829> All reviewed patches have been landed. Closing bug. |