Bug 103321

Summary: New check for usesTileCacheLayer on Windows needed after r133056
Product: WebKit Reporter: Roger Fong <roger_fong>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: rniwa, roger_fong, simon.fraser
Priority: P2 Keywords: LayoutTestFailure
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows 7   
Attachments:
Description Flags
patch simon.fraser: review+

Description Roger Fong 2012-11-26 16:51:42 PST 
After r133056 it no longer suffices to check use the existing usesTileCacheLayer method on Windows.

The change resulted in 3 crashing tests:

compositing/rotated-tiled-clamped
compositing/rotated-tiled-preserve3d-clamped
fast/events/tabindex-focus-blur-all

We should add in platform specific method for Windows that returns false for this method.

In addition, 
compositing/rotated-tiled-clamped
compositing/rotated-tiled-preserve3d-clamped

need to be removed from the Windows skip list and Windows specific results are needed since they were newly added tests with r133056.
Comment 1 Roger Fong 2012-11-26 17:02:11 PST 
Created attachment 176115 [details]
patch
Comment 2 Ryosuke Niwa 2012-11-27 11:57:35 PST 
This patch appears to have broken Mac builds:
http://trac.webkit.org/changeset/135890
http://build.webkit.org/builders/Apple%20Lion%20Debug%20%28Build%29/builds/8405

#elif
     ^
/Volumes/Data/slave/lion-debug/build/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:1055:21: error: no member named 'usesTileCacheLayer' in 'WebCore::PlatformCALayer'
    ASSERT(m_layer->usesTileCacheLayer());
    ~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~
/Volumes/Data/slave/lion-debug/build/WebKitBuild/Debug/usr/local/include/wtf/Assertions.h:247:8: note: expanded from macro 'ASSERT'
    (!(assertion) ? \
       ^
/Volumes/Data/slave/lion-debug/build/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:1607:19: error: no member named 'usesTileCacheLayer' in 'WebCore::PlatformCALayer'
    if (!m_layer->usesTileCacheLayer())
         ~~~~~~~  ^
Comment 3 Ryosuke Niwa 2012-11-27 12:01:49 PST 
Build fix landed in http://trac.webkit.org/changeset/135895.