Bug 103315

Summary:

HTMLFontElement font size parsing should directly handle 8 bit strings

Product:

WebKit

Reporter:

Michael Saboff <msaboff>

Component:

DOM

Assignee:

Michael Saboff <msaboff>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, dglazkov, ojan, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	oliver: review+, webkit.review.bot: commit-queue-

Michael Saboff

Reported 2012-11-26 16:18:18 PST

parseFontSize() in HTMLFontElement.cpp up converts 8 bit strings in order to parse the font size. 8 bit strings should be handled directly.

Attachments
Patch (2.59 KB, patch) 2012-11-26 16:23 PST, Michael Saboff	oliver: review+ webkit.review.bot: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Michael Saboff

Comment 1 2012-11-26 16:23:38 PST

WebKit Review Bot

Comment 2 2012-11-26 20:28:07 PST

Comment on attachment 176106 [details] Patch Attachment 176106 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15010022 New failing tests: inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html

Adam Barth

Comment 3 2012-11-28 08:58:05 PST

> inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html This seems likely to be a flaky test.

Adam Barth

Comment 4 2012-11-28 09:03:59 PST

I tried this patch locally and this test passed for me. We should probably mark it as flaky in TestExpectations.

Michael Saboff

Comment 5 2012-11-28 15:33:44 PST

Note You need to log in before you can comment on or make changes to this bug.