Bug 103298

Summary: Coordinated Graphics: Refactor code managing a backing store in LayerTreeRenderer.
Product: WebKit Reporter: Dongseong Hwang <dongseong.hwang>
Component: Layout and RenderingAssignee: Dongseong Hwang <dongseong.hwang>
Status: RESOLVED FIXED    
Severity: Normal CC: noam, webkit.review.bot, zeno
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 103171    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Dongseong Hwang
Reported 2012-11-26 14:46:07 PST
Coordinated Graphics: Refactor code managing a backing store in LayerTreeRenderer.
Attachments
Patch (11.20 KB, patch)
2012-11-26 14:48 PST, Dongseong Hwang 		no flags
DetailsFormatted DiffDiff
Patch (11.20 KB, patch)
2012-11-26 18:32 PST, Dongseong Hwang 		no flags
DetailsFormatted DiffDiff
Patch (11.20 KB, patch)
2012-11-26 19:34 PST, Dongseong Hwang 		no flags
DetailsFormatted DiffDiff
Patch (11.12 KB, patch)
2012-11-26 21:24 PST, Dongseong Hwang 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Dongseong Hwang
Comment 1 2012-11-26 14:46:26 PST
*** Bug 103215 has been marked as a duplicate of this bug. ***
Dongseong Hwang
Comment 2 2012-11-26 14:48:45 PST
Created attachment 176079 [details] Patch
Dongseong Hwang
Comment 3 2012-11-26 18:31:05 PST
It is strange. In new bug, this patch is purple too.
Noam Rosenthal
Comment 4 2012-11-26 18:32:13 PST
Looking at the changelog, seems like it's depending on the surface bug, which is not yet in.
Dongseong Hwang
Comment 5 2012-11-26 18:32:32 PST
Created attachment 176139 [details] Patch
Dongseong Hwang
Comment 6 2012-11-26 19:34:26 PST
Created attachment 176152 [details] Patch
Dongseong Hwang
Comment 7 2012-11-26 21:22:06 PST
(In reply to comment #4) > Looking at the changelog, seems like it's depending on the surface bug, which is not yet in. Oops! You're right! EWS is smart!
Dongseong Hwang
Comment 8 2012-11-26 21:24:40 PST
Created attachment 176164 [details] Patch
Noam Rosenthal
Comment 9 2012-11-26 21:35:54 PST
Comment on attachment 176164 [details] Patch Before this is committed, are the assert regressions from the previous patches all taken care of? I don't want to run too fast.
Dongseong Hwang
Comment 10 2012-11-26 21:42:56 PST
(In reply to comment #9) > (From update of attachment 176164 [details]) > Before this is committed, are the assert regressions from the previous patches all taken care of? I don't want to run too fast. I'm in progress. In the detail, I'll make GraphicsLayerTextureMapper traverse TextureMapperLayer tree. After that, TextureMapperLayer::flushCompositingState does not traverse recursively anymore. After that, I'll fix Bug 103171. LayerTreeRenderer::setLayerState can synchronize with TextureMapperLayer at that time. All will be finished today.
Zeno Albisser
Comment 11 2012-11-26 23:53:59 PST
(In reply to comment #9) > (From update of attachment 176164 [details]) > Before this is committed, are the assert regressions from the previous patches all taken care of? I don't want to run too fast. I am a bit concerned about the pace here as well. Lately i see a lot of patches going in in this area. And some of these touch quite integral parts of the architecture for several ports. I am also quite confident that some of the patches cause regressions. Not all of these are caught by LayoutTests unfortunately. It would be nice if we would at least get some time to check for such issues and to fix them.
Noam Rosenthal
Comment 12 2012-11-27 00:05:19 PST
(In reply to comment #11) > (In reply to comment #9) > > (From update of attachment 176164 [details] [details]) > > Before this is committed, are the assert regressions from the previous patches all taken care of? I don't want to run too fast. > > I am a bit concerned about the pace here as well. Lately i see a lot of patches going in in this area. And some of these touch quite integral parts of the architecture for several ports. > I am also quite confident that some of the patches cause regressions. Not all of these are caught by LayoutTests unfortunately. I agree. I might have been a bit hasty in my reviews; My sense was that the changes so far have been going in the right direction and that Huang was diligently following up on issues, but now we should go slower and if some regressions still exist either fix them or roll back.
Dongseong Hwang
Comment 13 2012-11-27 15:29:52 PST
(In reply to comment #12) > (In reply to comment #11) > > (In reply to comment #9) > > > (From update of attachment 176164 [details] [details] [details]) > > > Before this is committed, are the assert regressions from the previous patches all taken care of? I don't want to run too fast. > > > > I am a bit concerned about the pace here as well. Lately i see a lot of patches going in in this area. And some of these touch quite integral parts of the architecture for several ports. > > I am also quite confident that some of the patches cause regressions. Not all of these are caught by LayoutTests unfortunately. > > I agree. I might have been a bit hasty in my reviews; My sense was that the changes so far have been going in the right direction and that Huang was diligently following up on issues, but now we should go slower and if some regressions still exist either fix them or roll back. I think so. My mind has been a bit urgent in that I want to improve coordinated graphics ASAP. From now, I'll take more time to test and do my best to fix regressions.
WebKit Review Bot
Comment 14 2012-11-27 17:21:48 PST
Comment on attachment 176164 [details] Patch Clearing flags on attachment: 176164 Committed r135956: <http://trac.webkit.org/changeset/135956>
WebKit Review Bot
Comment 15 2012-11-27 17:21:53 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.