| Summary: | Coordinated Graphics: Refactor code managing a backing store in LayerTreeRenderer. | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Dongseong Hwang <dongseong.hwang> | ||||||||||
| Component: | Layout and Rendering | Assignee: | Dongseong Hwang <dongseong.hwang> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | noam, webkit.review.bot, zeno | ||||||||||
| Priority: | P2 | ||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Bug Depends on: | |||||||||||||
| Bug Blocks: | 103171 | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Dongseong Hwang
2012-11-26 14:46:07 PST
*** Bug 103215 has been marked as a duplicate of this bug. *** Created attachment 176079 [details]
Patch
It is strange. In new bug, this patch is purple too. Looking at the changelog, seems like it's depending on the surface bug, which is not yet in. Created attachment 176139 [details]
Patch
Created attachment 176152 [details]
Patch
(In reply to comment #4) > Looking at the changelog, seems like it's depending on the surface bug, which is not yet in. Oops! You're right! EWS is smart! Created attachment 176164 [details]
Patch
Comment on attachment 176164 [details]
Patch
Before this is committed, are the assert regressions from the previous patches all taken care of? I don't want to run too fast.
(In reply to comment #9) > (From update of attachment 176164 [details]) > Before this is committed, are the assert regressions from the previous patches all taken care of? I don't want to run too fast. I'm in progress. In the detail, I'll make GraphicsLayerTextureMapper traverse TextureMapperLayer tree. After that, TextureMapperLayer::flushCompositingState does not traverse recursively anymore. After that, I'll fix Bug 103171. LayerTreeRenderer::setLayerState can synchronize with TextureMapperLayer at that time. All will be finished today. (In reply to comment #9) > (From update of attachment 176164 [details]) > Before this is committed, are the assert regressions from the previous patches all taken care of? I don't want to run too fast. I am a bit concerned about the pace here as well. Lately i see a lot of patches going in in this area. And some of these touch quite integral parts of the architecture for several ports. I am also quite confident that some of the patches cause regressions. Not all of these are caught by LayoutTests unfortunately. It would be nice if we would at least get some time to check for such issues and to fix them. (In reply to comment #11) > (In reply to comment #9) > > (From update of attachment 176164 [details] [details]) > > Before this is committed, are the assert regressions from the previous patches all taken care of? I don't want to run too fast. > > I am a bit concerned about the pace here as well. Lately i see a lot of patches going in in this area. And some of these touch quite integral parts of the architecture for several ports. > I am also quite confident that some of the patches cause regressions. Not all of these are caught by LayoutTests unfortunately. I agree. I might have been a bit hasty in my reviews; My sense was that the changes so far have been going in the right direction and that Huang was diligently following up on issues, but now we should go slower and if some regressions still exist either fix them or roll back. (In reply to comment #12) > (In reply to comment #11) > > (In reply to comment #9) > > > (From update of attachment 176164 [details] [details] [details]) > > > Before this is committed, are the assert regressions from the previous patches all taken care of? I don't want to run too fast. > > > > I am a bit concerned about the pace here as well. Lately i see a lot of patches going in in this area. And some of these touch quite integral parts of the architecture for several ports. > > I am also quite confident that some of the patches cause regressions. Not all of these are caught by LayoutTests unfortunately. > > I agree. I might have been a bit hasty in my reviews; My sense was that the changes so far have been going in the right direction and that Huang was diligently following up on issues, but now we should go slower and if some regressions still exist either fix them or roll back. I think so. My mind has been a bit urgent in that I want to improve coordinated graphics ASAP. From now, I'll take more time to test and do my best to fix regressions. Comment on attachment 176164 [details] Patch Clearing flags on attachment: 176164 Committed r135956: <http://trac.webkit.org/changeset/135956> All reviewed patches have been landed. Closing bug. |