onloadeddata callback is not implemented on HTMLElement

• Component: Media
• Status: NEW ---

[Antoine Quint]

The HTMLElement interface defines an .onloadeddata property which we don't implement. This is making us fail the Opera-submitted test at http://w3c-test.org/html/tests/submission/Opera/media/interfaces/TextTrack/activeCues.html.

[Antoine Quint]

<rdar://problem/12756207>

[Eric Carlson]

Created attachment 177761 [details]
patch for another bug...

[Ahmad Saleem]

Safari Technology Preview 155 still fail some sub-tests:

https://wpt.fyi/results/html/semantics/embedded-content/media-elements/interfaces/TextTrack/activeCues.html?label=master&label=experimental&aligned&view=subtest&q=activecues

[Karl Dubost]

not sure the failures on activeCues are due to onloadeddata

Most of the subtests are passing there 
http://wpt.live/html/semantics/embedded-content/media-elements/interfaces/TextTrack/activeCues.html

For example the first test failing in Safari is

TextTrack.activeCues, empty list

For Safari
assert_not_equals(null, null, "t2.activeCues should not be null")
 /html/semantics/embedded-content/media-elements/interfaces/TextTrack/activeCues.html:32:22

For Firefox 
assert_not_equals(object "[object TextTrackCueList]", null, "t2.activeCues should not be null")
 /html/semantics/embedded-content/media-elements/interfaces/TextTrack/acti

And onloadeddata is called but this is on a VideoElement. 

This probably needs a different test. 


Antoine said:
HTMLElement interface defines an .onloadeddata property

Let's see 
https://html.spec.whatwg.org/multipage/dom.html#htmlelement


It's defined in the Global
https://html.spec.whatwg.org/multipage/webappapis.html#event-handlers-on-elements,-document-objects,-and-window-objects
> The following are the event handlers (and their corresponding event handler event types) that must be supported by all HTML elements, as both event handler content attributes and event handler IDL attributes; and that must be supported by all Document and Window objects, as event handler IDL attributes:



https://html.spec.whatwg.org/multipage/media.html#mediaevents
> The following events fire on media elements as part of the processing model described above:


In JSHTMLElement.cpp
https://searchfox.org/wubkat/source/__GENERATED__/WebCore/DerivedSources/JSHTMLElement.cpp#505


{ "onloadeddata"_s, JSC::PropertyAttribute::CustomAccessor | JSC::PropertyAttribute::DOMAttribute, NoIntrinsic, { HashTableValue::GetterSetterType, jsHTMLElement_onloadeddata, setJSHTMLElement_onloadeddata } },

[Ahmad Saleem]

Could we be hitting following?:

https://searchfox.org/wubkat/rev/7bf250e4832adfb28c2bf2bc518ad59958f2ae1b/Source/WebCore/html/track/TextTrackCueList.cpp#98

// FIXME: This list of active cues is not updated as cues are added, removed, become active, and become inactive.
// Instead it is only updated each time this function is called again. That is not consistent with other dynamic DOM lists.