Bug 103254 – Web Inspector: make ASSERTION FAILED: foundPropertiesCount == object->size() more useful

• Component: Web Inspector (Deprecated)
• Status: RESOLVED FIXED

[Pavel Feldman]

Adding dump of the JSON object would further improve the assertion value.

[Peter Rybin]

Pavel, please note that CodeGeneratorInspector.py has hardcoded variable VALIDATOR_IFDEF_NAME. This could be changed to use in release build mode.

[Peter Rybin]

Created attachment 176850 [details]
Patch

[Yury Semikhatsky]

Comment on attachment 176850 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=176850&action=review

> Source/WebCore/inspector/CodeGeneratorInspector.py:1342
> +                                        validator_writer.newline("      FATAL(\"Unexpected properties in object: %s\\n\", object->toJSONString().ascii().data());\n")

Now it will crash in release build too which is bad.

[Peter Rybin]

> Now it will crash in release build too which is bad.

This code doesn't work in release build.

[Yury Semikhatsky]

(In reply to comment #4)
> > Now it will crash in release build too which is bad.
> 
> This code doesn't work in release build.

Oh, I see it is hidden behind #if !ASSERT_DISABLED

[Peter Rybin]

Pavel, I guess the patch is at your service, ready for landing.

[Build Bot]

Comment on attachment 176850 [details]
Patch

Attachment 176850 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/15062675

[Peter Rybin]

Created attachment 177113 [details]
Patch

[Peter Rybin]

I guess the new patch fixes win build (linker .def file didn't list required function symbol).
Let's give it another try.

[WebKit Review Bot]

Comment on attachment 177113 [details]
Patch

Rejecting attachment 177113 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...
Updating OpenSource
From http://git.chromium.org/external/Webkit
   e9e6020..1db1bee  HEAD       -> origin/HEAD
error: Ref refs/remotes/origin/master is at 1db1bee680414c2b5d10e6b820eb7c7e89858e47 but expected e9e60209430c81c71b136baf1b1e72d6bac0da3a
 ! e9e6020..1db1bee  master     -> origin/master  (unable to update local ref)
Died at Tools/Scripts/update-webkit line 152.

Full output: http://queues.webkit.org/results/15133007

[WebKit Review Bot]

Comment on attachment 177113 [details]
Patch

Clearing flags on attachment: 177113

Committed r136431: <http://trac.webkit.org/changeset/136431>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.