Bug 10325

Summary:

[S60] Browser Control: Problem with History Stack when using custom datastore

Product:

WebKit

Reporter:

Joseph Ligman <joseph.ligman>

Component:

New Bugs

Assignee:

Nobody <webkit-unassigned>

Status:

CLOSED FIXED

Severity:

Normal

CC:

S60webkit, shyam.sareen

Priority:

Keywords:

PlatformOnly

Version:

420+

Hardware:

S60 Emulator

OS:

S60 3rd edition

URL:

A sample application and 5 HTML files in TSW

Attachments:

Description	Flags
Files: WebKitLoader.cpp, BufferTransaction.cpp	Sachin.Padma: review-
Files: WebKitLoader.cpp, BufferTransaction.cpp	Sachin.Padma: review+
Need additional fix: WebKitLoader.cpp	yongjun.zhang: review+

Description Joseph Ligman 2006-08-09 10:09:10 PDT

TSW Bug ID: VKRR-6PT7YV (Sample code in TSW)

Case with custom data store - Crash.
For the sake of simplicity, the custom data store for the sample application is simulated by overriding the ResolveLinkL function.  

1.) Open the file Proto1BCContainer.cpp and uncomment the block of code in TBool CProto1BCContainer::ResolveLinkL function. 
2.) Change "text\\html" to "text/html" in the same file
3.) Comment out lines 71 and 72 in Proto1BCView.cpp 

4) Compile the application in CodeWarrior
5.) Complie and run the application in the emulator
6.) The application can be found in installed folder\Proto1-1st
7.) Upon invokation, the 1st HTML page with embedded link to the 2nd page will be displayed.
8.) Traverse the link.
9.) There is a typo in the html link which causes line 190 to leave from the test application.
10.) Notice that the leave is not handled in BufferTransaction.cpp

Comment 1 Bradley Morrison 2006-08-09 12:22:35 PDT

Joe - please raise bugs in NEW state that you know are confirmed.

Thanks,
Bradley

Comment 2 Joseph Ligman 2006-08-09 16:32:00 PDT

Created attachment 9966 [details]
Files: WebKitLoader.cpp, BufferTransaction.cpp

This bug is an extension of bug 9667.

There is no data supplier provided for external links in LoadPage, so the data is not loaded. Also, client "leaves" are not handled from ResolveLinkL in the BufferTransaction's DoSubmit.function.

The test code is in TSW Bug ID: VKRR-6PT7YV. There are a few problems with the test code. 
1.) The file urls are not written correctly and the file parsing code needs to be adjusted once the urls are corrected.
2.) The content type should be text/html not text\\html

Comment 3 Yongjun Zhang 2006-08-14 11:29:35 PDT

ask Sachin to review this.

Comment 4 Sachin Padma 2006-08-16 11:07:29 PDT

Comment on attachment 9966 [details]
Files: WebKitLoader.cpp, BufferTransaction.cpp

Can you please use currect indentation and resubmit the patch

Comment 5 Joseph Ligman 2006-08-16 13:33:09 PDT

Created attachment 10077 [details]
Files: WebKitLoader.cpp, BufferTransaction.cpp

cleaned up indentation

Comment 6 Sachin Padma 2006-08-17 07:45:40 PDT

Comment on attachment 10077 [details]
Files: WebKitLoader.cpp, BufferTransaction.cpp

r=me

Comment 7 Sachin Padma 2006-08-17 07:48:51 PDT

committed as r15925

Comment 8 Krishna 2006-08-18 12:36:38 PDT

Closed.

Comment 9 Shyam Sareen 2007-01-29 09:12:09 PST

Created attachment 12744 [details]
Need additional fix: WebKitLoader.cpp

Comment 10 Yongjun Zhang 2007-01-29 14:28:06 PST

Comment on attachment 12744 [details]
Need additional fix: WebKitLoader.cpp

r=me

Comment 11 Bradley Morrison 2007-01-30 07:25:14 PST

(In reply to comment #9)
> Created an attachment (id=12744) [edit]
> Need additional fix: WebKitLoader.cpp
> 

please re-open bugs that need additional fixes. thx

Comment 12 Bradley Morrison 2007-01-30 07:28:55 PST

(In reply to comment #10)
> (From update of attachment 12744 [details] [edit])
> r=me
> 

landed - r19257. resolved.

Comment 13 Krishna 2007-02-19 17:08:57 PST

Verified and Closed.

Comment 14 Joel Parks 2011-03-21 11:52:28 PDT

re-purposing InTSW keyword for use by QtWebkit team