Bug 103241

Summary:

Adjust expectations for inspector/console/command-line-api-inspect.html and inspector/runtime/runtime-localStorage-getProperties.html

Product:

WebKit

Reporter:

Ulan Degenbaev <ulan>

Component:

Web Inspector (Deprecated)

Assignee:

Ulan Degenbaev <ulan>

Status:

RESOLVED INVALID

Severity:

Normal

CC:

apavlov, keishi, loislo, pfeldman, pmuellr, rossberg, vsevik, web-inspector-bugs, webkit.review.bot, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	apavlov: review+, buildbot: commit-queue-

Ulan Degenbaev

Reported 2012-11-26 04:34:20 PST

These two tests assume that Object.getOwnPropertyDescriptor on objects with interceptors doesn't return anything. This has been fixed in V8 3.15.5. LayoutTests/inspector/console/command-line-api-inspect.html LayoutTests/inspector/runtime/runtime-localStorage-getProperties.html

Attachments
Patch (2.62 KB, patch) 2012-11-26 04:39 PST, Ulan Degenbaev	no flags	Details Formatted Diff Diff
Patch (6.41 KB, patch) 2012-11-26 07:32 PST, Pavel Feldman	apavlov: review+ buildbot: commit-queue-	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Ulan Degenbaev

Comment 1 2012-11-26 04:39:44 PST

Created attachment 175970 [details] Patch

Build Bot

Comment 2 2012-11-26 07:16:51 PST

Comment on attachment 175970 [details] Patch Attachment 175970 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/14987664 New failing tests: inspector/runtime/runtime-localStorage-getProperties.html

Pavel Feldman

Comment 3 2012-11-26 07:21:35 PST

Comment on attachment 175970 [details] Patch This will be flaky: it dumps local storage content. I'll modify the test to get better expectations.

Pavel Feldman

Comment 4 2012-11-26 07:32:59 PST

Created attachment 176000 [details] Patch

Build Bot

Comment 5 2012-11-26 10:39:54 PST

Comment on attachment 176000 [details] Patch Attachment 176000 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/14986699 New failing tests: inspector/runtime/runtime-localStorage-getProperties.html inspector/console/command-line-api-inspect.html

Brian Burg

Comment 6 2014-12-12 13:40:03 PST

Closing as invalid, as this bug pertains to the old inspector UI and/or its tests. Please file a new bug (https://www.webkit.org/new-inspector-bug) if the bug/feature/issue is still relevant to WebKit trunk.

Note You need to log in before you can comment on or make changes to this bug.