Bug 103186

Summary: [EFL] Refactor RenderThemeEfl::getThemePartFromCache()
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit EFLAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, kenneth, laszlo.gombos, lucas.de.marchi, rakuco, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 103189    
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2012-11-24 12:22:23 PST
RenderThemeEfl::getThemePartFromCache() could be refactored to use a list instead of a vector. The function keep moving items to the head of the container which is efficient with a list but not with a vector. There is also some code duplication in the function that could be avoided.
Attachments
Patch (9.71 KB, patch)
2012-11-24 12:36 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2012-11-24 12:36:12 PST
Created attachment 175864 [details] Patch
Kenneth Rohde Christiansen
Comment 2 2012-11-24 13:03:46 PST
Comment on attachment 175864 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=175864&action=review > Source/WebCore/ChangeLog:11 > + Refactor getThemePartFromCache() so that a list is used > + for the cache instead of a vector. The function moves > + items to the head of the container which is much more > + efficient with a list than a vector. Ah nice, I wanted to do this at some point but forgot all about it
WebKit Review Bot
Comment 3 2012-11-24 14:25:56 PST
Comment on attachment 175864 [details] Patch Clearing flags on attachment: 175864 Committed r135658: <http://trac.webkit.org/changeset/135658>
WebKit Review Bot
Comment 4 2012-11-24 14:26:00 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.