Summary: | Removing unnecessary friend classes in RenderObject: LayoutRepainter, RenderSVGContainer | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Adenilson Cavalcanti Silva <savagobr> | ||||||
Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | eric, ojan, simon.fraser, webkit.review.bot | ||||||
Priority: | P3 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Adenilson Cavalcanti Silva
2012-11-23 18:37:57 PST
Created attachment 175843 [details]
The patch v01
I suspect that having RenderLayer be the only possible caller of that function may have been part of the original intention. Still I think having it public is probably a better design. I've CC'd Simon in case he'd like to comment. Eric Just to confirm, should I send another patch with previous changes *and* make RenderObject's functions (setPreviousSibling, setNextSibling, setParent) no longer protected? That would free the remaining classes from having friend access to RenderObject. Comment on attachment 175843 [details]
The patch v01
Please put the declaration for outlineBoundsForRepaint() just under rectWithOutlineForRepaint().
This patch is fine as is. I'm not sure it makes sense to make setPreviousSibling, etc. generically public, as those are dangerous functions. It's unclear why any code would need to access those anyway? Thanks for the patch. Created attachment 176068 [details]
Implementing reviewers suggestion (location of moved function)
Now outlineBoundsForRepaint() follows just after rectWithOutlineForRepaint().
Comment on attachment 176068 [details] Implementing reviewers suggestion (location of moved function) Clearing flags on attachment: 176068 Committed r135779: <http://trac.webkit.org/changeset/135779> All reviewed patches have been landed. Closing bug. |