Bug 103159

Summary:

Removing unnecessary RenderBox friend access in RenderObject

Product:

WebKit

Reporter:

Adenilson Cavalcanti Silva <savagobr>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, darin, eric, hyatt, kenneth, ojan, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
The patch v01	none

Adenilson Cavalcanti Silva

Reported 2012-11-23 12:52:43 PST

RenderObject has several classes marked as friend, thus allowing full access to its private and protected members. Between those friends, one of them (RenderBox) is actually derived from it indirectly and is not accessing its forefather private data members/functions. This patch removes the unnecessary friend keyword from RenderObject.

Attachments
The patch v01 (1.80 KB, patch) 2012-11-23 13:00 PST, Adenilson Cavalcanti Silva	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Adenilson Cavalcanti Silva

Comment 1 2012-11-23 13:00:44 PST

Created attachment 175835 [details] The patch v01

Eric Seidel (no email)

Comment 2 2012-11-23 13:50:33 PST

Comment on attachment 175835 [details] The patch v01 I assume this was for accessing private: members? RenderBlock and REnderSVGContainer also derive from RenderObject.

WebKit Review Bot

Comment 3 2012-11-23 14:04:54 PST

Comment on attachment 175835 [details] The patch v01 Clearing flags on attachment: 175835 Committed r135633: <http://trac.webkit.org/changeset/135633>

WebKit Review Bot

Comment 4 2012-11-23 14:04:58 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.