Bug 103144 – [EFL] Crashes in compositing layout tests with AC on.

• Component: WebKit EFL
• Status: RESOLVED FIXED

[Viatcheslav Ostapenko]

There are crashes in compositing tests when AC was on.

  compositing/absolute-position-changed-with-composited-parent-layer.html [ Crash ]
  compositing/geometry/flipped-writing-mode.html [ Crash ]
  compositing/geometry/layer-due-to-layer-children-deep-switch.html [ Crash ]
  compositing/geometry/outline-change.html [ Crash ]
  compositing/geometry/repaint-foreground-layer.html [ Crash ]
  compositing/iframes/iframe-resize.html [ Crash ]
  compositing/iframes/invisible-nested-iframe-hide.html [ Crash ]
  compositing/iframes/invisible-nested-iframe-show.html [ Crash ]
  compositing/iframes/overlapped-iframe-iframe.html [ Crash ]
  compositing/iframes/overlapped-nested-iframes.html [ Crash ]
  compositing/iframes/page-cache-layer-tree.html [ Crash ]
  compositing/iframes/scroll-grandchild-iframe.html [ Crash ]
  compositing/reflections/load-video-in-reflection.html [ Crash ]
  compositing/tiling/backface-preserve-3d-tiled.html [ Crash ]
  compositing/visibility/visibility-simple-video-layer.html [ Crash ]
  transforms/3d/point-mapping/3d-point-mapping-preserve-3d.html [ Crash ]
  transforms/3d/point-mapping/3d-point-mapping.html [ Crash ]

0	??	/lib/i386-linux-gnu/libc.so.6	0	0xb17da1a0	
1	memcpy_texture	string3.h	52	0xae945ac7	
2	_mesa_texstore_argb8888	texstore.c	1393	0xae94e3c9	
3	_mesa_texstore	texstore.c	4386	0xae94f171	
4	store_texsubimage	texstore.c	4517	0xae94f421	
5	_mesa_store_texsubimage2d	texstore.c	4653	0xae94f9a5	
6	texsubimage	teximage.c	2807	0xae93a324	
7	texsubimage	teximage.c	2750	0xae93da31	
8	_mesa_TexSubImage2D	teximage.c	2852	0xae93da31	
9	WebCore::GraphicsContext3D::texSubImage2D	GraphicsContext3DOpenGLCommon.cpp	1312	0xb4fed0d2	
10	WebCore::BitmapTextureGL::updateContentsNoSwizzle	TextureMapperGL.cpp	696	0xb4ff4861	
11	WebCore::BitmapTextureGL::updateContents	TextureMapperGL.cpp	749	0xb4ff4c69	
12	WebCore::BitmapTextureGL::updateContents	TextureMapperGL.cpp	773	0xb4ff4d0e	
13	WebCore::TextureMapperTile::updateContents	TextureMapperBackingStore.cpp	80	0xb45d3e05	
14	WebCore::TextureMapperTiledBackingStore::updateContents	TextureMapperBackingStore.cpp	197	0xb45d481b	
15	WebCore::TextureMapperLayer::updateBackingStore	TextureMapperLayer.cpp	139	0xb45d7024	
16	WebCore::TextureMapperLayer::flushCompositingState	TextureMapperLayer.cpp	559	0xb45d8c0e	
17	WebCore::TextureMapperLayer::flushCompositingState	TextureMapperLayer.cpp	570	0xb45d8cb6	
18	WebCore::TextureMapperLayer::flushCompositingState	TextureMapperLayer.cpp	570	0xb45d8cb6	
19	WebCore::TextureMapperLayer::flushCompositingState	TextureMapperLayer.cpp	570	0xb45d8cb6	
20	WebCore::TextureMapperLayer::flushCompositingState	TextureMapperLayer.cpp	570	0xb45d8cb6	
21	WebCore::TextureMapperLayer::flushCompositingState	TextureMapperLayer.cpp	570	0xb45d8cb6	
22	WebCore::TextureMapperLayer::flushCompositingState	TextureMapperLayer.cpp	411	0xb45d826c	
23	WebCore::GraphicsLayerTextureMapper::flushCompositingState	GraphicsLayerTextureMapper.cpp	386	0xb4fd21d3	
24	WebCore::RenderLayerCompositor::flushPendingLayerChanges	RenderLayerCompositor.cpp	323	0xb478240c	
25	WebCore::FrameView::flushCompositingStateForThisFrame	FrameView.cpp	839	0xb449c8d0	
26	WebCore::FrameView::paintContents	FrameView.cpp	3220	0xb44a4dbc	
27	WebCore::ScrollView::paint	ScrollView.cpp	1075	0xb454402f	
28	ewk_paint_context_paint	ewk_paint_context.cpp	178	0xb1d8e121	
29	ewk_view_paint	ewk_view.cpp	2961	0xb1db9f06	
30	_ewk_view_single_smart_repaints_process	ewk_view_single.cpp	277	0xb1dcbe43	
31	_ewk_view_smart_calculate	ewk_view.cpp	1142	0xb1da18c8	
32	evas_call_smarts_calculate	evas_object_smart.c	838	0xb19f7aad	
33	evas_render_updates_internal	evas_render.c	1248	0xb1a2659e	
34	_ecore_evas_x_render	ecore_evas_x.c	288	0xb1bd94b4	
35	_ecore_evas_idle_enter	ecore_evas.c	59	0xb1bd59ce	
36	_ecore_call_task_cb	ecore_private.h	265	0xb1bff742	
37	_ecore_idle_enterer_call	ecore_idle_enterer.c	168	0xb1bff742	
38	_ecore_main_loop_iterate_internal	ecore_main.c	1826	0xb1c01105	
39	ecore_main_loop_begin	ecore_main.c	934	0xb1c017ef	
40	runTest	DumpRenderTree.cpp	289	0x80b965f	
41	main	DumpRenderTree.cpp	463	0x80b9ee3

[Viatcheslav Ostapenko]

Those crashes happen because evas leaves non-zero GL_UNPACK_ROW_LENGTH on GL context. Simple workaround is possible, but now all AC is broken on EFL WK1 after r135468 : https://bugs.webkit.org/show_bug.cgi?id=103179

[Viatcheslav Ostapenko]

Created attachment 175875 [details]
Patch

[WebKit Review Bot]

Comment on attachment 175875 [details]
Patch

Attachment 175875 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/14990177

New failing tests:
svg/W3C-SVG-1.1/animate-elem-52-t.svg

[WebKit Review Bot]

Comment on attachment 175875 [details]
Patch

Rejecting attachment 175875 [details] from commit-queue.

New failing tests:
inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html
Full output: http://queues.webkit.org/results/14991476

[Viatcheslav Ostapenko]

Comment on attachment 175875 [details]
Patch

Unrelated flaky test.

[WebKit Review Bot]

Comment on attachment 175875 [details]
Patch

Clearing flags on attachment: 175875

Committed r135731: <http://trac.webkit.org/changeset/135731>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.