Bug 103104

Summary: [BlackBerry] Should not autofill username and password when there're more than one password inputs on the same page
Product: WebKit Reporter: Jonathan Dong <jonathan.dong.webkit>
Component: WebKit BlackBerryAssignee: Jonathan Dong <jonathan.dong.webkit>
Status: RESOLVED FIXED    
Severity: Normal CC: charles.wei, mifenton, rwlbuis, staikos, tonikitoo, webkit.review.bot, yong.li.webkit
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Jonathan Dong
Reported 2012-11-23 00:44:47 PST
RIM PR: 245334 If there're more than one password input field in the same page, we should not autofill the username and password we've saved.
Attachments
Patch (6.88 KB, patch)
2012-11-25 16:22 PST, Jonathan Dong 		no flags
DetailsFormatted DiffDiff
Patch (6.87 KB, patch)
2012-11-25 22:12 PST, Jonathan Dong 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jonathan Dong
Comment 1 2012-11-25 16:22:01 PST
Created attachment 175894 [details] Patch
Rob Buis
Comment 2 2012-11-25 16:30:43 PST
Comment on attachment 175894 [details] Patch LGTM.
WebKit Review Bot
Comment 3 2012-11-25 20:58:03 PST
Comment on attachment 175894 [details] Patch Rejecting attachment 175894 [details] from commit-queue. New failing tests: svg/W3C-SVG-1.1/animate-elem-78-t.svg Full output: http://queues.webkit.org/results/14987480
Jonathan Dong
Comment 4 2012-11-25 22:00:05 PST
(In reply to comment #3) > (From update of attachment 175894 [details]) > Rejecting attachment 175894 [details] from commit-queue. > > New failing tests: > svg/W3C-SVG-1.1/animate-elem-78-t.svg > Full output: http://queues.webkit.org/results/14987480 I believe this is an occasional issue because this patch only affected the code for BlackBerry porting, and our porting haven't got a working DRT in webkit.org. I'll try again later.
Jonathan Dong
Comment 5 2012-11-25 22:12:18 PST
Created attachment 175922 [details] Patch
WebKit Review Bot
Comment 6 2012-11-26 02:54:44 PST
Comment on attachment 175922 [details] Patch Clearing flags on attachment: 175922 Committed r135699: <http://trac.webkit.org/changeset/135699>
WebKit Review Bot
Comment 7 2012-11-26 02:54:48 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.