Bug 103083

Summary: -webkit-mask shorthand switches -webkit-mask-clip and -webkit-mask-origin values
Product: WebKit Reporter: Dirk Schulze <krit>
Component: CSSAssignee: Dirk Schulze <krit>
Status: RESOLVED FIXED    
Severity: Normal CC: hyatt, simon.fraser, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 95389    
Attachments:
Description Flags
Patch none

Description Dirk Schulze 2012-11-22 10:09:05 PST
I wrote a test for -webkit-mask and found a problem with the handling of <box>{1,2} values (-webkit-mask-clip and -webkit-mask-origin). What ever you do, the values always get switched. This is not the case for background:

PASS innerStyle("background", "none padding-box content-box") is "none padding-box content-box"
PASS innerStyle("background", "none content-box padding-box") is "none content-box padding-box"
FAIL innerStyle("-webkit-mask", "none padding-box content-box") should be none padding-box content-box. Was none content-box padding-box.
FAIL innerStyle("-webkit-mask", "none content-box padding-box") should be none content-box padding-box. Was none padding-box content-box.

Same happens in all combination of <box>: border-box, padding-box and content-box.
Comment 1 Dirk Schulze 2012-11-22 10:11:58 PST
Looks like the problem is in const StylePropertyShorthand& webkitMaskShorthand(), where both properties are in the wrong order.
Comment 2 Dirk Schulze 2012-11-22 12:56:33 PST
Created attachment 175704 [details]
Patch
Comment 3 Dirk Schulze 2012-11-22 21:09:35 PST
Comment on attachment 175704 [details]
Patch

Clearing flags on attachment: 175704

Committed r135556: <http://trac.webkit.org/changeset/135556>
Comment 4 Dirk Schulze 2012-11-22 21:09:38 PST
All reviewed patches have been landed.  Closing bug.