Bug 103060

Summary: Merge EditingText into Text
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: HTML EditingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: d-r, fmalita, gyuyoung.kim, kling, mifenton, ojan, pdr, rakuco, rniwa, schenney, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
patch 2 rniwa: review+, buildbot: commit-queue-

Antti Koivisto
Reported 2012-11-22 05:38:06 PST
EditingText is a Text that always creates a renderer. It can be replaced by a bit.
Attachments
patch (28.59 KB, patch)
2012-11-22 06:26 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
patch 2 (22.81 KB, patch)
2012-11-22 06:48 PST, Antti Koivisto 		rniwa: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2012-11-22 06:26:01 PST
Created attachment 175661 [details] patch
Antti Koivisto
Comment 2 2012-11-22 06:48:31 PST
Created attachment 175666 [details] patch 2
WebKit Review Bot
Comment 3 2012-11-22 06:50:39 PST
Attachment 175666 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/W..." exit_code: 1 Source/WebCore/editing/ReplaceSelectionCommand.cpp:55: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 13 files If any of these errors are false positives, please file a bug against check-webkit-style.
Build Bot
Comment 4 2012-11-22 07:35:02 PST
Comment on attachment 175666 [details] patch 2 Attachment 175666 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/14960372
Ryosuke Niwa
Comment 5 2012-11-22 08:40:58 PST
Comment on attachment 175666 [details] patch 2 View in context: https://bugs.webkit.org/attachment.cgi?id=175666&action=review > Source/WebCore/dom/Node.h:320 > + bool hasName() const { ASSERT(!isTextNode()); return getFlag(HasNameOrIsEditingTextFlag); } These two statements should probably be put in separate lines. > Source/WebCore/dom/Node.h:334 > + bool isEditingText() const { ASSERT(isTextNode()); return getFlag(HasNameOrIsEditingTextFlag); } Ditto. > Source/WebCore/dom/Node.h:336 > + void setHasName(bool f) { ASSERT(!isTextNode()); setFlag(f, HasNameOrIsEditingTextFlag); } Ditto.
Antti Koivisto
Comment 6 2012-11-22 09:35:36 PST
http://trac.webkit.org/changeset/135529
Note You need to log in before you can comment on or make changes to this bug.