Bug 103031

Summary:

Better type ahead for DateTimeSymbolicFieldElement

Product:

WebKit

Reporter:

Keishi Hattori <keishi>

Component:

Forms

Assignee:

Keishi Hattori <keishi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dglazkov, gyuyoung.kim, mifenton, ojan, rakuco, tkent, webkit-ews, webkit.review.bot

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

103620, 103834

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none

Keishi Hattori

Reported 2012-11-22 00:16:41 PST

Better type ahead for DateTimeSymbolicFieldElement. We want to support cycling and multiple character prefix.

Attachments
Patch (24.34 KB, patch) 2012-11-26 01:37 PST, Keishi Hattori	no flags	Details Formatted Diff Diff
Patch (31.13 KB, patch) 2012-11-26 05:34 PST, Keishi Hattori	no flags	Details Formatted Diff Diff
Patch (31.00 KB, patch) 2012-11-26 05:35 PST, Keishi Hattori	no flags	Details Formatted Diff Diff
Patch (31.02 KB, patch) 2012-11-26 05:49 PST, Keishi Hattori	no flags	Details Formatted Diff Diff
Patch (31.52 KB, patch) 2012-11-26 05:57 PST, Keishi Hattori	no flags	Details Formatted Diff Diff
Patch (31.30 KB, patch) 2012-11-29 00:17 PST, Keishi Hattori	no flags	Details Formatted Diff Diff
Patch (31.30 KB, patch) 2012-11-29 00:31 PST, Keishi Hattori	no flags	Details Formatted Diff Diff
Patch (31.27 KB, patch) 2012-11-29 04:02 PST, Keishi Hattori	no flags	Details Formatted Diff Diff
Patch (31.19 KB, patch) 2012-11-29 20:53 PST, Keishi Hattori	no flags	Details Formatted Diff Diff
Show Obsolete (8) View All Add attachment proposed patch, testcase, etc.

Keishi Hattori

Comment 1 2012-11-26 01:37:44 PST

Created attachment 175941 [details] Patch

Early Warning System Bot

Comment 2 2012-11-26 01:47:02 PST

Comment on attachment 175941 [details] Patch Attachment 175941 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/14981596

Early Warning System Bot

Comment 3 2012-11-26 01:48:12 PST

Comment on attachment 175941 [details] Patch Attachment 175941 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/15003041

Kent Tamura

Comment 4 2012-11-26 01:49:36 PST

Comment on attachment 175941 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=175941&action=review > Source/WebCore/ChangeLog:16 > + * WebCore.gypi: Added TypeAhead.{h,cpp} You need to add these files to many other build files. > Source/WebCore/html/HTMLSelectElement.h:111 > + // TypeAheadDataSource methods. > + virtual int indexOfSelectedOption() const OVERRIDE; > + virtual int optionCount() const OVERRIDE; > + virtual String optionAtIndex(int index) const OVERRIDE; Let's make them private because they shouldn't be called by non-TypeAhead code. > Source/WebCore/html/TypeAhead.cpp:2 > + * Copyright (C) 2012 Google Inc. All rights reserved. You have to respect the copyright of the original code.

Kent Tamura

Comment 5 2012-11-26 02:04:57 PST

Comment on attachment 175941 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=175941&action=review > Source/WebCore/html/TypeAhead.cpp:51 > + int length = string.length(); > + > + int i; nit: They should be unsigned. > Source/WebCore/html/TypeAhead.cpp:79 > + m_buffer.append(c); We should avoid String::append. m_buffer should be a StringBuilder or a Vector. > Source/WebCore/html/TypeAhead.h:47 > + int handleEvent(KeyboardEvent*); You had better add a comment about the return value.

Keishi Hattori

Comment 6 2012-11-26 05:34:43 PST

Created attachment 175974 [details] Patch

Keishi Hattori

Comment 7 2012-11-26 05:35:53 PST

Created attachment 175975 [details] Patch

Build Bot

Comment 8 2012-11-26 05:38:32 PST

Comment on attachment 175975 [details] Patch Attachment 175975 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/14989565

EFL EWS Bot

Comment 9 2012-11-26 05:41:16 PST

Comment on attachment 175975 [details] Patch Attachment 175975 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/14987640

WebKit Review Bot

Comment 10 2012-11-26 05:42:00 PST

Comment on attachment 175975 [details] Patch Attachment 175975 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14986586

Keishi Hattori

Comment 11 2012-11-26 05:49:23 PST

Created attachment 175979 [details] Patch

EFL EWS Bot

Comment 12 2012-11-26 05:55:51 PST

Comment on attachment 175979 [details] Patch Attachment 175979 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/14981673

Keishi Hattori

Comment 13 2012-11-26 05:57:43 PST

Created attachment 175981 [details] Patch

Kent Tamura

Comment 14 2012-11-26 18:20:48 PST

Comment on attachment 175981 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=175981&action=review > Source/WebCore/html/TypeAhead.h:59 > + void setMatchMode(MatchModeFlags); nit: We can remove setMatchMode and m_matchMode by adding MatchModeFlags argument to handleEvent. It's up to you to do it.

Keishi Hattori

Comment 15 2012-11-29 00:17:53 PST

Created attachment 176662 [details] Patch

Keishi Hattori

Comment 16 2012-11-29 00:31:27 PST

Created attachment 176665 [details] Patch

WebKit Review Bot

Comment 17 2012-11-29 01:16:47 PST

Comment on attachment 176665 [details] Patch Clearing flags on attachment: 176665 Committed r136111: <http://trac.webkit.org/changeset/136111>

WebKit Review Bot

Comment 18 2012-11-29 01:16:52 PST

All reviewed patches have been landed. Closing bug.