Bug 102945

Summary: Path::addBeziersForRoundedRect can emit degenerate cubics
Product: WebKit Reporter: Tom Hudson <tomhudson>
Component: Layout and RenderingAssignee: Tom Hudson <tomhudson>
Status: RESOLVED FIXED    
Severity: Normal CC: jianli, senorblanco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Tom Hudson
Reported 2012-11-21 08:06:57 PST
Path::addBeziersForRoundedRect calls addBezierCurveTo(), even for corners where both radii are 0. This is easy to suppress, and the resulting partially-round rects are still correct.
Attachments
Patch (3.86 KB, patch)
2012-11-21 08:09 PST, Tom Hudson 		no flags
DetailsFormatted DiffDiff
Patch for landing (3.91 KB, patch)
2012-11-21 08:25 PST, Tom Hudson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tom Hudson
Comment 1 2012-11-21 08:09:20 PST
Created attachment 175451 [details] Patch
Stephen White
Comment 2 2012-11-21 08:21:52 PST
Comment on attachment 175451 [details] Patch Looks fine (although this code could use some refactoring). Please add a line to the ChangeLog about test coverage on landing. r=me
Tom Hudson
Comment 3 2012-11-21 08:25:39 PST
Created attachment 175453 [details] Patch for landing
WebKit Review Bot
Comment 4 2012-11-21 09:28:46 PST
Comment on attachment 175453 [details] Patch for landing Clearing flags on attachment: 175453 Committed r135411: <http://trac.webkit.org/changeset/135411>
WebKit Review Bot
Comment 5 2012-11-21 09:28:49 PST
All reviewed patches have been landed. Closing bug.
Stephen White
Comment 7 2012-11-21 12:14:31 PST
I'm seeing flakiness in scrollbars on Mac 10.7 Debug. If it's just a few tests, I'd say don't roll it out just now. My suspicion is that the patch didn't introduce new flakiness, just moved it around between tests.
Tom Hudson
Comment 8 2012-11-22 02:52:51 PST
(In reply to comment #6) > There're quite a few test failures caused by this patch. > > http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fast%2Fframes%2FonlyCommentInIFrame.html%2Cfast%2Fframes%2Fvalid.html%2Cfast%2Fframes%2Fiframe-scaling-with-scroll.html%2Cfast%2Fframes%2Fiframe-scrolling-attribute.html I'm not sure why you're pointing at this patch; it looks to me like those have been quite flaky ever since WebKit r135309.
Note You need to log in before you can comment on or make changes to this bug.