Bug 102896

Summary: Coordinated Graphics: refactor changing children code in CoordinatedGraphicsLayer.
Product: WebKit Reporter: Dongseong Hwang <dongseong.hwang>
Component: Layout and RenderingAssignee: Dongseong Hwang <dongseong.hwang>
Status: RESOLVED FIXED    
Severity: Normal CC: noam, webkit.review.bot, zeno
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Dongseong Hwang
Reported 2012-11-21 00:54:56 PST
When changing children, we don't need to sync a layer state. We were confused that we have to send a parent layer id to UI Process, but r133605 clarified passing the parent id is not necessary. So this patch removes didChangeLayerState() in methods which change children. In addition, purgeBackingStores() does not need to call didChangeChildren() because purgeBackingStores() does not change children. r133605 is Bug 101142.
Attachments
Patch (4.47 KB, patch)
2012-11-21 00:58 PST, Dongseong Hwang 		no flags
DetailsFormatted DiffDiff
Patch (4.34 KB, patch)
2012-11-21 14:19 PST, Dongseong Hwang 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dongseong Hwang
Comment 1 2012-11-21 00:58:10 PST
Created attachment 175366 [details] Patch
Dongseong Hwang
Comment 2 2012-11-21 00:58:35 PST
It is a follow-up patch to Bug 101142.
Noam Rosenthal
Comment 3 2012-11-21 07:02:31 PST
Comment on attachment 175366 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=175366&action=review > Source/WebKit2/ChangeLog:14 > + When changing children, we don't need to sync a layer state. We were confused > + that we have to send a parent layer id to UI Process, but r133605 clarified > + passing the parent id is not necessary. So this patch removes > + didChangeLayerState() in methods which change children. > + > + In addition, purgeBackingStores() does not need to call didChangeChildren() > + because purgeBackingStores() does not change children. I wouldn't say we were confused, in the past behavior of GraphicsLayer we did have to send the parent. I would reword this to say "There is no more need to send the parent ID every time the layer tree hierarchy changes."
Dongseong Hwang
Comment 4 2012-11-21 14:19:05 PST
Created attachment 175523 [details] Patch
Dongseong Hwang
Comment 5 2012-11-21 14:20:05 PST
(In reply to comment #3) > I wouldn't say we were confused, in the past behavior of GraphicsLayer we did have to send the parent. > I would reword this to say "There is no more need to send the parent ID every time the layer tree hierarchy changes." Thank you for review. Changelog can be more refined!
WebKit Review Bot
Comment 6 2012-11-21 15:22:22 PST
Comment on attachment 175523 [details] Patch Clearing flags on attachment: 175523 Committed r135443: <http://trac.webkit.org/changeset/135443>
WebKit Review Bot
Comment 7 2012-11-21 15:22:26 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.