Bug 102885

Summary:

Web Inspector: "switch" code style in TimelinePresentationModel.js

Product:

WebKit

Reporter:

pdeng6 <pan.deng>

Component:

Web Inspector (Deprecated)

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, keishi, loislo, pfeldman, pmuellr, vivek.vg, vsevik, web-inspector-bugs, webkit.review.bot, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none

pdeng6

Reported 2012-11-20 23:20:08 PST

switch and case are not aligned in function _getRecordDetails

Attachments
Patch (7.74 KB, patch) 2012-11-21 00:11 PST, pdeng6	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

pdeng6

Comment 1 2012-11-21 00:11:59 PST

Created attachment 175353 [details] Patch

Vivek Galatage

Comment 2 2012-11-21 20:34:43 PST

(In reply to comment #1) > Created an attachment (id=175353) [details] > Patch I think we rarely do just code alignment patches. If you have a fix to some bug or some feature in this area, you can club this code alignment along with that.

pdeng6

Comment 3 2012-11-21 21:27:05 PST

(In reply to comment #2) > (In reply to comment #1) > > Created an attachment (id=175353) [details] [details] > > Patch > I think we rarely do just code alignment patches. If you have a fix to some bug or some feature in this area, you can club this code alignment along with that. yep, this is a trivial change. I did touch these code in https://bugs.webkit.org/show_bug.cgi?id=101910, and was asked to seperate format change in new one from Pavel. or I mis-understood? thanks. :)

WebKit Review Bot

Comment 4 2012-11-22 12:31:47 PST

Comment on attachment 175353 [details] Patch Clearing flags on attachment: 175353 Committed r135537: <http://trac.webkit.org/changeset/135537>

WebKit Review Bot

Comment 5 2012-11-22 12:31:50 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.