Bug 102875

Summary: REGRESSION(r133859): This patch makes API test broken (Requested by gyuyoung on #webkit).
Product: WebKit Reporter: WebKit Review Bot <webkit.review.bot>
Component: New BugsAssignee: WebKit Review Bot <webkit.review.bot>
Status: RESOLVED FIXED    
Severity: Normal CC: kenneth, yael
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 101526    
Attachments:
Description Flags
ROLLOUT of r133859 none

WebKit Review Bot
Reported 2012-11-20 22:00:11 PST
http://trac.webkit.org/changeset/133859 broke the build: This patch makes API test broken (Requested by gyuyoung on #webkit). This is an automatic bug report generated by the sheriff-bot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests case pain. "Only you can prevent forest fires." -- Smokey the Bear
Attachments
ROLLOUT of r133859 (2.81 KB, patch)
2012-11-20 22:00 PST, WebKit Review Bot 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
WebKit Review Bot
Comment 1 2012-11-20 22:00:55 PST
Created attachment 175336 [details] ROLLOUT of r133859 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment.
WebKit Review Bot
Comment 2 2012-11-20 22:06:26 PST
Comment on attachment 175336 [details] ROLLOUT of r133859 Clearing flags on attachment: 175336 Committed r135350: <http://trac.webkit.org/changeset/135350>
WebKit Review Bot
Comment 3 2012-11-20 22:06:30 PST
All reviewed patches have been landed. Closing bug.
Kenneth Rohde Christiansen
Comment 4 2012-11-21 01:50:41 PST
You don't roll out such old patches without prior discussion. Did you even look into fixing the one failing unit test first?
Note You need to log in before you can comment on or make changes to this bug.